[fix] Added jq devbox dependency and fixed missing /bin directory #658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change:
The jq library is used by certain e2e tests, but it is not included in the devbox setup. If a user is running the tests without jq installed locally, some tests will fail because jq is not present.
When running
make e2etest
before the/bin
directory has been created bymake tools
ormkdir bin
, the command will fail because the/bin
directory can't be found. One way to fix this would be addingtools
to the dependencies fore2etest
, but building the various tools individually (e.g.make gowrap
) would still fail until the user makes the/bin
directory. Instead, this change creates the directory any time any of the tools are built individually or withmake tools
(assuming it doesn't already exist). This also avoids needing to individually add thetools
dependency to other builds (e.g. test).TODOs: