Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix] Added jq devbox dependency and fixed missing /bin directory #658

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Andrews2024
Copy link
Contributor

Reason for change:
The jq library is used by certain e2e tests, but it is not included in the devbox setup. If a user is running the tests without jq installed locally, some tests will fail because jq is not present.
When running make e2etest before the /bin directory has been created by make tools or mkdir bin, the command will fail because the /bin directory can't be found. One way to fix this would be adding tools to the dependencies for e2etest, but building the various tools individually (e.g. make gowrap) would still fail until the user makes the /bin directory. Instead, this change creates the directory any time any of the tools are built individually or with make tools (assuming it doesn't already exist). This also avoids needing to individually add the tools dependency to other builds (e.g. test).

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@github-actions github-actions bot added the bugfix label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.21%. Comparing base (a11c323) to head (17c20ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   63.21%   63.21%           
=======================================
  Files          70       70           
  Lines        6090     6090           
=======================================
  Hits         3850     3850           
  Misses       1976     1976           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrews2024 Andrews2024 merged commit 161f424 into main Feb 4, 2025
13 checks passed
@AshleyDumaine AshleyDumaine deleted the fix-local-testing-dependencies branch February 4, 2025 17:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants