Skip to content

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Feb 4, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

tchinmai7 and others added 30 commits February 16, 2024 05:30
Refactor into distinct packages to prep for adding firewall support to Nodes
* add route-controller to linode ccm

* store vpc id in route_controller

* address review comments

* fix internal ip for nodes, fix tests and address review comments

* address review comments

* Update cloud/linode/route_controller.go

Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>

---------

Co-authored-by: Rahul Sharma <rahsharm@akamai.com>
Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>
* disable conn-throttle by default

* set to 0 only if nothing is specified:

* update readmne
)

Co-authored-by: Rahul Sharma <rahsharm@akamai.com>
Co-authored-by: Rahul Sharma <rahsharm@akamai.com>
… nodebalancer nodes (#192)

Fixing the nodebalancer config rebuilds to include ids of preexisting nodebalancer nodes to avoid rebuilds.

+ tests
+ Bumping k8s deps and updating CCM to reflect new API
+ Fixing node_controller and service_controller due to changes in k8s api.
+ upgrading toolchain
+ Bumping CI's go version
+ Adding build deps/tools to separate file
+ Refactored client mocks to generate just one file and dropped the two copies which existed due to _test.go in name, that prevents the code to be imported
Fix typo in README where in example is invalid json.
fix-readme: firewall-acl invalid json
* Lookup linode by IP if label does not match and ProviderID is not set

---------

Co-authored-by: Alex Vest <avestuk@gmail.com>
…ound for issue #200 which some users are experiencing (#204)
* add back changes reverted in PR #195

* get instanceConfig only when running within VPC

* add and fix unittests

* use lock when reading/writing vpc id

* updated route-controller using /v4/vpcs/ips api

* fix tests

* switch to new api returning ips for specific vpc

* when running with vpc set, only cache instances which are part of VPC

* address review comments

* update linodego to v1.33.0

* address review comment, make variable required if routecontroller is enabled

---------

Co-authored-by: Rahul Sharma <rahsharm@akamai.com>
Set toolchain go1.22.2 go.mod
update client to work for v4beta API
[bugfix] - handle LoadBalancer deletion if service type changes to no longer be a LoadBalancer
Primarily to get the token obfuscation feature in this release: https://github.com/linode/linodego/releases/tag/v1.34.0

This means that if one enables LINODE_DEBUG to understand all Linode API calls, tokens will no longer be printed out.
komer3 and others added 27 commits January 17, 2025 14:15
Bumps [github.com/linode/linodego](https://github.com/linode/linodego) from 1.44.1 to 1.46.0.
- [Release notes](https://github.com/linode/linodego/releases)
- [Commits](linode/linodego@v1.44.1...v1.46.0)

---
updated-dependencies:
- dependency-name: github.com/linode/linodego
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the kubernetes group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.32.0` | `0.32.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.0` | `0.32.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.0` | `0.32.1` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.32.0` | `0.32.1` |
| [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.32.0` | `0.32.1` |


Updates `k8s.io/api` from 0.32.0 to 0.32.1
- [Commits](kubernetes/api@v0.32.0...v0.32.1)

Updates `k8s.io/apimachinery` from 0.32.0 to 0.32.1
- [Commits](kubernetes/apimachinery@v0.32.0...v0.32.1)

Updates `k8s.io/client-go` from 0.32.0 to 0.32.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.32.0...v0.32.1)

Updates `k8s.io/cloud-provider` from 0.32.0 to 0.32.1
- [Commits](kubernetes/cloud-provider@v0.32.0...v0.32.1)

Updates `k8s.io/component-base` from 0.32.0 to 0.32.1
- [Commits](kubernetes/component-base@v0.32.0...v0.32.1)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/cilium/cilium](https://github.com/cilium/cilium) from 1.16.5 to 1.16.6.
- [Release notes](https://github.com/cilium/cilium/releases)
- [Changelog](https://github.com/cilium/cilium/blob/1.16.6/CHANGELOG.md)
- [Commits](cilium/cilium@1.16.5...1.16.6)

---
updated-dependencies:
- dependency-name: github.com/cilium/cilium
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[docs] refactor/organizing docs
Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.6.1 to 2.7.0.
- [Release notes](https://github.com/helm/chart-testing-action/releases)
- [Commits](helm/chart-testing-action@v2.6.1...v2.7.0)

---
updated-dependencies:
- dependency-name: helm/chart-testing-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jetify-com/devbox-install-action](https://github.com/jetify-com/devbox-install-action) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/jetify-com/devbox-install-action/releases)
- [Commits](jetify-com/devbox-install-action@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: jetify-com/devbox-install-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/helm/chart-releaser-action/releases)
- [Commits](helm/chart-releaser-action@v1.6.0...v1.7.0)

---
updated-dependencies:
- dependency-name: helm/chart-releaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[feat] add linode token health check
* delete fw if provisioned by CCM with ACL

* address review comments

* add e2e test to check firewall is deleted on ACL and service deletion
* Expose Linode Client Prometheus metrics

Add `--authorization-always-allow-paths="/metrics"` to command line to
allow scraping these metrics.

In addition to Linode Client metrics, standard controller and worqueue
metrics are visible by default.

To disambiguate CCM node controller work queue name, it's explicitly
named "ccm_node". That is, "node", "service" are upstream work
queues of k8s cloud-provider service controller and "ccm_node" is
the work queue of Linode CCM node controller.

Fixes #296

* Ignore coverage for client_with_metrics.go

* Add allowUnauthorizedMetrics Helm value

* Move metrics docs to getting-started sections

* Instrument healthChecker with Prometheus metrics

* Update newHealthChecker tests

* Preserve initialization order

* Remove unused timeout variable in healthChecker

* Remove unnecessary err return in newHealthChecker
* add environment for e2e tests

* checkout pull request head

* fix test failing due to service getting deleted and retry failing
Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.6-0.20210604193023-d5e0c0615ace to 1.0.6.
- [Release notes](https://github.com/spf13/pflag/releases)
- [Commits](https://github.com/spf13/pflag/commits/v1.0.6)

---
updated-dependencies:
- dependency-name: github.com/spf13/pflag
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/linode/linodego](https://github.com/linode/linodego) from 1.46.0 to 1.47.0.
- [Release notes](https://github.com/linode/linodego/releases)
- [Commits](linode/linodego@v1.46.0...v1.47.0)

---
updated-dependencies:
- dependency-name: github.com/linode/linodego
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rahulait rahulait marked this pull request as ready for review February 4, 2025 18:55
@rahulait rahulait merged commit c5e3926 into gh-pages Feb 4, 2025
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.