Added support for updated Reserved IP behavior to existing resources (instance, network_ips) #610

AniJ98 · 2024-11-08T17:10:27Z

📝 Description

This PR implements functionality and tests for managing Reserved IP addresses in the Linodego client. These changes align with the updated Linode API, providing comprehensive support for Reserved IP operations. The changes include:

Implementation of core operations:

Deleting a Linode while retaining the Reserved IP
Retrieving IP information for Linodes, including Reserved IPs
Listing all IP addresses, including Reserved IPs
Allocating and assigning new Reserved IP addresses
Assigning Reserved IPs to Linodes
Fetching particular IP address, including Reserved IPs
Converting between Ephemeral and Reserved IPs

Test coverage:

TestInstance_DeleteInstanceVariants: Verifies Reserved IP retention after Linode deletion
TestReservedIPAddresses_GetIPReservationStatus: Tests retrieval of Linode IP information including Reserved IPs
TestIPAddresses_List_smoke: Checks filtering of all IPs by the reserved field.
TestIPAddress_Instance_Allocate: Covers various scenarios for allocating Reserved IPs
TestIPAddress_Instance_ReserveIP_Assign: Tests assigning Reserved IPs to Linodes
TestIPAddress_GetFound: Tests fetching information about a particular IP address, including Reseved IPs
TestIPAddress_Update: Verifies conversion between Ephemeral and Reserved IPs

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

Ensure you have a valid Linode API token. Set up your environment:

export LINODE_TOKEN="your_token_here"

Additionally you need to set the following if you want to test it in a different environment:

export LINODE_URL="https://api.linode.com
export LINODE_API_VERSION="v4beta"

Navigate to the test directory within the linodego project. Update the LINODE_TOKEN in the Makefile:

LINODE_TOKEN="your_token_here"

Run the tests using one of the following commands: To run all integration tests:

make testint

To run a specific test:

go test -v ./integration -run TestInstance_DeleteInstanceVariants

Verify the test output for any failures or unexpected behavior.

Note:
Ensure that you have enough quota to reserve IP before adding it to an existing linode. Ensure the IPMAX limit is enough to allocate/ assign a reserved IP to a linode.

…dresses

…d, InsuffecientPermission, ReserveIP, GetReservedIP, getReservedIPs, DeleteReservedIPs

…ns to reserve IP

…mission tests

…y appropriate error message along with code

…ord user with adequate permissions

…ther functions

…d fatalf wherever necessary

…es with latest error messages

… feature. Removed for loop to reserve IPs till limit is reached.

…d fixtures to reflect new error messages

* build(deps): bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.22.0 to 0.23.0. - [Commits](golang/oauth2@v0.22.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Ran make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ezilber-akamai <ezilber@akamai.com>

* build(deps): bump golang.org/x/text from 0.17.0 to 0.18.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.17.0 to 0.18.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ye Chen <yechen@akamai.com>

…ing endpoints (linode#573) * Add LKE types endpoints * Support base struct; add NB types endpoints * Add volume types * Add network transfer prices * Add price and region price structs * Revert IPv6 fixtures * Add missing fixtures

…th associated tests

… the corresponding tests and fixtures

…tance to instance_ips.go

…ual test funcitons and removed debugging log statements

…st functions, made changes to error messages

…g addresses of a linode

…nd corresponding tests

…nd recorded new ones for allocating and assigning reserved IPs

…ality

Added support for updated Reserved IP behavior to existing resources (instance, network_ips)

lgarber-akamai · 2024-11-14T18:55:09Z

test/integration/network_ips_test.go

+
+	reservedIP, err = createReservedIP()
+	if err == nil {
+		t.Fatalf("Expected error indicating MAX IP Reservation limit has been reached, got nil")


We typically try to design tests to be account/limit-agnostic so I think we can remove this case

Got it! I will go ahead and remove this test.

lgarber-akamai · 2024-11-14T19:19:24Z

network_ips.go

+// AllocateReserveIP allocates a new IPv4 address to the Account, with the option to reserve it
+// and optionally assign it to a Linode.
+func (c *Client) AllocateReserveIP(ctx context.Context, opts LinodeReserveIPOptions) (*InstanceIP, error) {
+	e := "networking/ips"


This isn't quite related to this PR but I'm curious about what the difference between POST networking/reserved/ips and POST networking/ips (with reserved == true) is. Is the latter effectively just an alias of the former with a bit more functionality?

That is a good question! We are currently supporting creation of reserved IP's through both POST networking/reserved/ips and POST networking/ips (with reserved == true). The only difference is that along with creation we are also able to assign reserved IP's to linodes using POST networking/ips (with reserved == true).

Got it, thanks!

lgarber-akamai · 2024-11-14T19:24:43Z

This PR looks great other than a few small things!

The CI failure should have been fixed in this PR so merge from main should get the linter passing 🙂

…d field in the IPAddressUpdateOptions struct

Removed test for exceeding IP MAX and changed the type of the reserve…

lgarber-akamai · 2024-11-18T20:14:26Z

network_ips.go

@@ -16,6 +17,14 @@ type LinodeIPAssignment struct {
 	LinodeID int    `json:"linode_id"`
 }

+type LinodeReserveIPOptions struct {


nitpick: Could this be renamed to AllocateReserveIPOptions?

Yes! I will make the change now

…ptions

Changed struct name from LinodeReserveIPOptions to AllocateReserveIPO…

lgarber-akamai

All tests are passing on my end, great work and thanks for the contribution!

ezilber-akamai

Looks good and tests are passing locally. Thanks for the contribution!

* Support missing domain-related endpoints for API parity (#620) * update domains * nit * test: Update default test image to reflect the deprecation of Debian 9 support (#623) * update tests since debian9 support ended * update tests since debian9 support ended * Added support for updated Reserved IP behavior to existing resources (instance, network_ips) (#610) * added reserved field to InstanceIP struct for IP Reservation response * Reserved IP resource for handling IP reservation API's * Added integration test covering multiple scenarios of reserving IP addresses * The fixture files for different scenarios of IP Reservation - EndToEnd, InsuffecientPermission, ReserveIP, GetReservedIP, getReservedIPs, DeleteReservedIPs * Updated the fixture files with responses after the user has permissions to reserve IP * Changed the error message to relay invalid token for insufficient permission tests * Updated the error message for Insufficient Permission tests to display appropriate error message along with code * Made changes to Delete, List, Get, Reserve, EndtoEnd fixtures to record user with adequate permissions * changed variable name from id to address to keep it consistent with other functions * Made changes to variable names, achanged logf statements to errorf and fatalf wherever necessary * changed fixture file names to improve consistency, re-recorded fixtures with latest error messages * removed debugging fmt statement * Made changes to reserve IP addresses before listing them using fitler feature. Removed for loop to reserve IPs till limit is reached. * uncommenting unaffected tests * Made changes to error messages, added mandatory checks and re-recorded fixtures to reflect new error messages * Added new middleware system (#571) * build(deps): bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 (#574) * build(deps): bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.22.0 to 0.23.0. - [Commits](golang/oauth2@v0.22.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Ran make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ezilber-akamai <ezilber@akamai.com> * build(deps): bump golang.org/x/text from 0.17.0 to 0.18.0 (#575) * build(deps): bump golang.org/x/text from 0.17.0 to 0.18.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.17.0 to 0.18.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ye Chen <yechen@akamai.com> * new: Add support LKE, Volume, NodeBalancer, and network transfer # endpoints (#573) * Add LKE types endpoints * Support base struct; add NB types endpoints * Add volume types * Add network transfer prices * Add price and region price structs * Revert IPv6 fixtures * Add missing fixtures * Add test case for ip limit exceed * add cleanup for TestReservedIPAddresses_ExceedLimit * added interactions to fixture and changed the ecpected error message * Added note indicating feature is currently not available to all users * added support for creating a linode with reserved IP address along with associated tests * Added support for adding additional reserved IP to linodes along with the corresponding tests and fixtures * added ipv4 field in the InstanceCreateOptions struct * moved InstanceReservedIPOptions and the method to AddReservedIPToInsatance to instance_ips.go * Split the variants tests of createInstanceWithReservedIP into individual test funcitons and removed debugging log statements * Re-recorded fixtures after splitting variants test into individual test functions, made changes to error messages * added teardown funcitnality to handle accidental instance creations * removed unnecessary defer keyword from test functions * moved tests related to creating a linode with reserved IP and adding additonal reserved IPs to a linode to a separate file * Removing the sensitive token from the previous commit * made changes to maintain consistency and improve readability * added tests for deletion of linode created with reserved IP address * added test for verifying the status of the reserved field when listing addresses of a linode * Added support for existing resources to support reserved IP feature and corresponding tests * Updated fixtures with required interactions for reserved IP feature and recorded new ones for allocating and assigning reserved IPs * changed the name of the test function to keeop it more succinct * setting reserved as an optional field * Made change to make reserved a part of the update IP address functionality * Removed test for exceeding IP MAX and changed the type of the reserved field in the IPAddressUpdateOptions struct * Changed struct name from LinodeReserveIPOptions to AllocateReserveIPOptions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Erik Zilber <ezilber@akamai.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ye Chen <yechen@akamai.com> Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com> Co-authored-by: ykim-1 <ykim@akamai.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> * build(deps): bump github.com/go-resty/resty/v2 from 2.16.1 to 2.16.2 (#629) * build(deps): bump github.com/go-resty/resty/v2 from 2.16.1 to 2.16.2 Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.16.1 to 2.16.2. - [Release notes](https://github.com/go-resty/resty/releases) - [Commits](go-resty/resty@v2.16.1...v2.16.2) --- updated-dependencies: - dependency-name: github.com/go-resty/resty/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> * build(deps): bump slackapi/slack-github-action from 1.27.0 to 2.0.0 (#619) * build(deps): bump slackapi/slack-github-action from 1.27.0 to 2.0.0 Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.27.0 to 2.0.0. - [Release notes](https://github.com/slackapi/slack-github-action/releases) - [Commits](slackapi/slack-github-action@v1.27.0...v2.0.0) --- updated-dependencies: - dependency-name: slackapi/slack-github-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix payloads * fix smoke test --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> Co-authored-by: ykim-1 <ykim@akamai.com> Co-authored-by: Youjung Kim <126618609+ykim-akamai@users.noreply.github.com> * doc: Remove Image Services Gen2 LA notice (#628) * remove la * oops * build(deps): bump github.com/stretchr/testify from 1.9.0 to 1.10.0 (#631) * build(deps): bump github.com/stretchr/testify from 1.9.0 to 1.10.0 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> * build(deps): bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 (#608) * build(deps): bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.23.0 to 0.24.0. - [Commits](golang/oauth2@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> * build(deps): bump golang.org/x/net from 0.30.0 to 0.31.0 (#614) * build(deps): bump golang.org/x/net from 0.30.0 to 0.31.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.30.0 to 0.31.0. - [Commits](golang/net@v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> * doc: add info for kubeconfig as base64 (#607) Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> * Added support for missing User-related fields (#622) * Added support for missing user fields * Reran GetMonthlyTransfer fixture * Add hardware type and linode label fields to volume struct (#604) * Add hardware type and linode label fields to volume struct * Update tests * build(deps): bump golang.org/x/text from 0.20.0 to 0.21.0 (#638) * build(deps): bump golang.org/x/text from 0.20.0 to 0.21.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.20.0 to 0.21.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.20.0...v0.21.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ye Chen <yechen@akamai.com> * build(deps): bump golang.org/x/net from 0.31.0 to 0.32.0 (#637) * build(deps): bump golang.org/x/net from 0.31.0 to 0.32.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.31.0 to 0.32.0. - [Commits](golang/net@v0.31.0...v0.32.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> * Updated migrations field to be pointer (#639) * Added support for missing Service Transfer related endpoints (#632) * Added support for service transfers * Fix lint * Reran GetMonthlyTransfer fixture * Added support for missing Obj-related endpoints (#634) * Added missing obj related endpoints * Fix lint * Added unit test * Fixed time format to match API response * Reran GetMonthlyTransfer fixture * Addressed PR comments * Ran make tidy * add account test coverage (#636) * new: Introduce UpdateIPAddressV2; deprecate UpdateIPAddress (#641) * Introduce UpdateIPAddressV2; deprecate UpdateIPAddress * Update fixtures * Add advanced CodeQL and dependencies review workflows (#640) * NewClient panics if http.client is nil and LINODE_CA is set (#635) I tried a new linodego with a custom CA and a nil HTTP client and encountered a panic. Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> * build(deps): bump golang.org/x/net from 0.32.0 to 0.33.0 (#646) * build(deps): bump golang.org/x/net from 0.32.0 to 0.33.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.32.0 to 0.33.0. - [Commits](golang/net@v0.32.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> Co-authored-by: Erik Zilber <ezilber@akamai.com> * Support DBaaS V2.0 (#633) * Implemented changes for DBaaS v2.0 and added deprecation notices * Added fork field to ManagedDB struct * Addressed PR comments * Addressed more PR comments * build(deps): bump golang.org/x/net from 0.33.0 to 0.34.0 (#650) * build(deps): bump golang.org/x/net from 0.33.0 to 0.34.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.33.0 to 0.34.0. - [Commits](golang/net@v0.33.0...v0.34.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy * Update the fixture --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lena Garber <lgarber@akamai.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> * build(deps): bump golang.org/x/oauth2 from 0.24.0 to 0.25.0 (#648) * build(deps): bump golang.org/x/oauth2 from 0.24.0 to 0.25.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.24.0 to 0.25.0. - [Commits](golang/oauth2@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> * Remove unnecessary permissions (#643) * Add unit test coverage for Type, Vlan and Tag related methods/functions (#647) * types_unit_tests * vlan_tests * unit_test_tag * address_PR_comments * fix * fix lint * VPU Support (#645) ## 📝 Description **What does this PR do and why is this change necessary?** Adds `AcceleratedDevices` to `Instnace.Stats` and `GET linode/types` Also adds `NETINT Quadra T1U` Capability enum. ## ✔️ How to Test **How do I run the relevant unit/integration tests?** ``` make fixtures ARGS="-run TestInstance_withVPU" ``` * Support `tier` field for LKE-E (#651) * Support tier field for LKE-E * Reran fixture for failing test * build(deps): bump github.com/go-resty/resty/v2 from 2.16.2 to 2.16.3 (#653) * build(deps): bump github.com/go-resty/resty/v2 from 2.16.2 to 2.16.3 Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.16.2 to 2.16.3. - [Release notes](https://github.com/go-resty/resty/releases) - [Commits](go-resty/resty@v2.16.2...v2.16.3) --- updated-dependencies: - dependency-name: github.com/go-resty/resty/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ye Chen <yechen@akamai.com> * Add support for object storage services gen2 (#649) * rfc: doPOSTRequestNoResponseBody (#654) Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com> * Add unit test coverage for Stackscripts, Database and Region related methods/functions (#652) * unit_tests * add_test * database_tests * test/workflow: Update make test commands and related workflows (#657) * update make test commands and workflows * add TEST_ARGS to unit and integration test commands * roll back boto3 version for test report upload * Added missign db-related fields (#659) * remove unnecessary TEST_ARGS (#664) * build(deps): bump github.com/go-resty/resty/v2 from 2.16.3 to 2.16.5 (#662) * build(deps): bump github.com/go-resty/resty/v2 from 2.16.3 to 2.16.5 Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.16.3 to 2.16.5. - [Release notes](https://github.com/go-resty/resty/releases) - [Commits](go-resty/resty@v2.16.3...v2.16.5) --- updated-dependencies: - dependency-name: github.com/go-resty/resty/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> * Checking for DefaultTransport in NewClient (#663) * new tests * do not compare against defaulttransport * Add unit test coverage for Volume,Volume types and Longview related methods/functions (#661) * unit_tests * add_test * database_tests * volume_unittests * fix * fix * longview_tests * fix int_test * Reformatted endpoint functions to simplify them (#668) * add domain and domain record unit test coverage (#656) * build(deps): bump crazy-max/ghaction-github-labeler from 5.1.0 to 5.2.0 (#667) Bumps [crazy-max/ghaction-github-labeler](https://github.com/crazy-max/ghaction-github-labeler) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/crazy-max/ghaction-github-labeler/releases) - [Commits](crazy-max/ghaction-github-labeler@b54af0c...31674a3) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com> Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> * build(deps): bump golang.org/x/oauth2 from 0.25.0 to 0.26.0 (#672) * build(deps): bump golang.org/x/oauth2 from 0.25.0 to 0.26.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.25.0 to 0.26.0. - [Commits](golang/oauth2@v0.25.0...v0.26.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lena Garber <lgarber@akamai.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> * remove deprecated Cluster variable in tests (#666) * Allow to enable LKE APL (#665) * apl enable * lint * nit * Ran make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com> Co-authored-by: Youjung Kim <126618609+ykim-akamai@users.noreply.github.com> Co-authored-by: AniJ98 <ajagadis@akamai.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ye Chen <yechen@akamai.com> Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com> Co-authored-by: ykim-1 <ykim@akamai.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com> Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> Co-authored-by: Guilhem Lettron <guilhem@barpilot.io> Co-authored-by: Ondrej Kokes <ondrej.kokes@gmail.com> Co-authored-by: Lena Garber <lgarber@akamai.com> Co-authored-by: Vinay <143587840+vshanthe@users.noreply.github.com>

AniJ98 and others added 30 commits September 16, 2024 16:04

added reserved field to InstanceIP struct for IP Reservation response

1b87e78

Reserved IP resource for handling IP reservation API's

311ecfc

Added integration test covering multiple scenarios of reserving IP ad…

7fb337e

…dresses

The fixture files for different scenarios of IP Reservation - EndToEn…

1c6a8ab

…d, InsuffecientPermission, ReserveIP, GetReservedIP, getReservedIPs, DeleteReservedIPs

Updated the fixture files with responses after the user has permissio…

fd426cc

…ns to reserve IP

Changed the error message to relay invalid token for insufficient per…

bed7ce0

…mission tests

Updated the error message for Insufficient Permission tests to displa…

4cc42a6

…y appropriate error message along with code

Made changes to Delete, List, Get, Reserve, EndtoEnd fixtures to rec…

11fd3cb

…ord user with adequate permissions

changed variable name from id to address to keep it consistent with o…

4d24fd1

…ther functions

Made changes to variable names, achanged logf statements to errorf an…

a265fd4

…d fatalf wherever necessary

changed fixture file names to improve consistency, re-recorded fixtur…

49d14a6

…es with latest error messages

removed debugging fmt statement

bd106fa

Made changes to reserve IP addresses before listing them using fitler…

cd7fa48

… feature. Removed for loop to reserve IPs till limit is reached.

uncommenting unaffected tests

d52a33f

Made changes to error messages, added mandatory checks and re-recorde…

cb81bc2

…d fixtures to reflect new error messages

Added new middleware system (linode#571)

456d0f2

Add test case for ip limit exceed

3bb8dc0

add cleanup for TestReservedIPAddresses_ExceedLimit

ce34304

added interactions to fixture and changed the ecpected error message

8627e4f

Added note indicating feature is currently not available to all users

663e798

Merge branch 'main' into main

5bb2bc1

added support for creating a linode with reserved IP address along wi…

138c163

…th associated tests

Added support for adding additional reserved IP to linodes along with…

4b44bd8

… the corresponding tests and fixtures

added ipv4 field in the InstanceCreateOptions struct

35610a0

moved InstanceReservedIPOptions and the method to AddReservedIPToInsa…

809b407

…tance to instance_ips.go

Split the variants tests of createInstanceWithReservedIP into individ…

b559ee8

…ual test funcitons and removed debugging log statements

Re-recorded fixtures after splitting variants test into individual te…

402c77a

…st functions, made changes to error messages

AniJ98 added 9 commits September 30, 2024 17:17

added test for verifying the status of the reserved field when listin…

c9a70b8

…g addresses of a linode

Added support for existing resources to support reserved IP feature a…

2752177

…nd corresponding tests

Updated fixtures with required interactions for reserved IP feature a…

30435e2

…nd recorded new ones for allocating and assigning reserved IPs

changed the name of the test function to keeop it more succinct

25bcf81

Merge branch 'linode:main' into main

2157efd

setting reserved as an optional field

62d2550

Made change to make reserved a part of the update IP address function…

4789287

…ality

Merge pull request #6 from AniJ98/ipreservation-remainingendpoints

968f780

Added support for updated Reserved IP behavior to existing resources (instance, network_ips)

Merge branch 'linode:main' into main

8a19216

AniJ98 requested a review from a team as a code owner November 8, 2024 17:10

AniJ98 requested review from lgarber-akamai and ezilber-akamai and removed request for a team November 8, 2024 17:10

Merge branch 'main' into main

2181fb1

lgarber-akamai reviewed Nov 14, 2024

View reviewed changes

AniJ98 added 3 commits November 14, 2024 17:00

Removed test for exceeding IP MAX and changed the type of the reserve…

b716ca2

…d field in the IPAddressUpdateOptions struct

Merge branch 'main' into main

e809bf8

Merge pull request #7 from AniJ98/ipreservation-remainingendpoints

0fbe6ff

Removed test for exceeding IP MAX and changed the type of the reserve…

lgarber-akamai self-requested a review November 18, 2024 16:01

lgarber-akamai reviewed Nov 18, 2024

View reviewed changes

AniJ98 added 3 commits November 18, 2024 15:15

Merge branch 'main' into main

73a1b3b

Changed struct name from LinodeReserveIPOptions to AllocateReserveIPO…

4af2cc7

…ptions

Merge pull request #8 from AniJ98/ipreservation-remainingendpoints

0a45fcd

Changed struct name from LinodeReserveIPOptions to AllocateReserveIPO…

lgarber-akamai self-requested a review November 18, 2024 20:25

lgarber-akamai approved these changes Nov 18, 2024

View reviewed changes

ezilber-akamai approved these changes Nov 19, 2024

View reviewed changes

lgarber-akamai merged commit 90fe250 into linode:main Nov 25, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for updated Reserved IP behavior to existing resources (instance, network_ips) #610

Added support for updated Reserved IP behavior to existing resources (instance, network_ips) #610

AniJ98 commented Nov 8, 2024

lgarber-akamai Nov 14, 2024

AniJ98 Nov 14, 2024

lgarber-akamai Nov 14, 2024 •

edited

Loading

AniJ98 Nov 14, 2024

lgarber-akamai Nov 18, 2024

lgarber-akamai commented Nov 14, 2024 •

edited

Loading

lgarber-akamai Nov 18, 2024

AniJ98 Nov 18, 2024

lgarber-akamai left a comment

ezilber-akamai left a comment

Added support for updated Reserved IP behavior to existing resources (instance, network_ips) #610

Added support for updated Reserved IP behavior to existing resources (instance, network_ips) #610

Conversation

AniJ98 commented Nov 8, 2024

📝 Description

✔️ How to Test

lgarber-akamai Nov 14, 2024

Choose a reason for hiding this comment

AniJ98 Nov 14, 2024

Choose a reason for hiding this comment

lgarber-akamai Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

AniJ98 Nov 14, 2024

Choose a reason for hiding this comment

lgarber-akamai Nov 18, 2024

Choose a reason for hiding this comment

lgarber-akamai commented Nov 14, 2024 • edited Loading

lgarber-akamai Nov 18, 2024

Choose a reason for hiding this comment

AniJ98 Nov 18, 2024

Choose a reason for hiding this comment

lgarber-akamai left a comment

Choose a reason for hiding this comment

ezilber-akamai left a comment

Choose a reason for hiding this comment

lgarber-akamai Nov 14, 2024 •

edited

Loading

lgarber-akamai commented Nov 14, 2024 •

edited

Loading