Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: [M3-9410] - Unable to save non-US billing contact info without tax id #11725

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Feb 25, 2025

Description 📝

Customers report that they are unable to update their Billing address without entering a Tax ID which they do not have as an individual/non-business entity. This should be an optional field.

Changes 🔄

  • Removed the condition that makes this required

Target release date 🗓️

2/25

Preview 📷

Before After
Screenshot 2025-02-25 at 1 09 16 PM Screenshot 2025-02-25 at 1 08 58 PM

How to test 🧪

Verification steps

  • Ensure non-US users can update their contact information without a tax id
  • Ensure US users can update their contact information properly
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • [x ] All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai added the Hotfix Hotfix: This is going to staging label Feb 25, 2025
@jaalah-akamai jaalah-akamai self-assigned this Feb 25, 2025
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner February 25, 2025 18:10
@jaalah-akamai jaalah-akamai requested review from hasyed-akamai and bill-akamai and removed request for a team February 25, 2025 18:10
coliu-akamai
coliu-akamai previously approved these changes Feb 25, 2025
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirming can update non US addresses without a tax ID
✅ confirming I can still update my US address

thank you

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
Copy link

github-actions bot commented Feb 25, 2025

Coverage Report:
Base Coverage: 79.98%
Current Coverage: 79.98%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing518 Passing3 Skipped114m 2s

Details

Failing Tests
SpecTest
clone-linode.spec.tsclone linode » can clone a Linode from Linode details page
linode-config.spec.tsEnd-to-End » Clones a config
edit-system-alert.spec.tsIntegration Tests for Edit Alert » should correctly display and update the details of the alert in the edit alert page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/cloudpulse/edit-system-alert.spec.ts"

@jaalah-akamai jaalah-akamai merged commit f6d6fc5 into linode:staging Feb 25, 2025
22 of 23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Hotfix Hotfix: This is going to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants