Skip to content

Commit

Permalink
devconfig: install-deps is skipped in some configurations
Browse files Browse the repository at this point in the history
A recent commit replaced import_tasks with include_tasks in a few
steps in the devconfig playbook.

The Ansible "import_tasks" documentation says:

> Tags are not interpreted for this action, they are applied to the
> imported tasks

Revert some of the import_tasks conversions to ensure those steps
are run according to the command-line tag settings.

For the original problem that I tripped on, add tags to ensure those
sub-steps get run as needed.

Reported-by: Joel Granados <joel.granados@kernel.org>
Closes: https://lore.kernel.org/kdevops/20250128112453.rawxqvpffxwupvco@AALNPWDAGOMEZ1.aal.scsc.local/T/#t
Fixes: ec9a34e ("devconfig: Replace import_tasks with include_tasks")
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Tested-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
  • Loading branch information
chucklever committed Jan 29, 2025
1 parent 1f3811c commit 4da8c43
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions playbooks/roles/devconfig/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@
# Distro specific
- name: Install dependencies
ansible.builtin.include_tasks: install-deps/main.yml
tags: ['vars', 'vars_simple']

- name: Configure custom repositories and install packages
ansible.builtin.include_tasks: config-custom-repos-and-packages/main.yml
ansible.builtin.import_tasks: config-custom-repos-and-packages/main.yml
when:
- ansible_facts['os_family']|lower == 'redhat'

Expand Down Expand Up @@ -447,7 +448,7 @@
tags: [ 'console' ]

- name: Update your boot GRUB file if necessary
ansible.builtin.include_tasks: update-grub/main.yml
ansible.builtin.import_tasks: update-grub/main.yml
when:
- grub2_config_file.stat.exists
- devconfig_enable_console|bool
Expand Down Expand Up @@ -637,7 +638,7 @@
tags: [ 'sysctl' ]

- name: Rev the kernel to the latest distribution kotd
ansible.builtin.include_tasks: kotd-rev-kernel/main.yml
ansible.builtin.import_tasks: kotd-rev-kernel/main.yml
when:
- devconfig_enable_kotd|bool
tags: [ 'kotd' ]

0 comments on commit 4da8c43

Please # to comment.