fix: network_state must be defined in defaults/main.yml #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
===========================================
+ Coverage 20.50% 43.22% +22.72%
===========================================
Files 10 12 +2
Lines 1478 3100 +1622
Branches 433 0 -433
===========================================
+ Hits 303 1340 +1037
- Misses 1174 1760 +586
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[citest] |
As part of the public API, `network_state` must be defined in
defaults/main.yml, and it must be defined with the correct
type `dict`, so the correct default value must be `{}` the
empty dict.
All checking for `network_state` must check for a value of
`{}` to mean "network_state not set or empty".
Fix the test which looks for teaming configuration in EL10
to correctly look for the value in `network_state`.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
force-pushed
the
network-state-in-defaults
branch
from
91790df to
e7294a1
Compare
|
[citest] |
liangwen12year
approved these changes
Jul 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the public API,
network_statemust be defined indefaults/main.yml, and it must be defined with the correct
type
dict, so the correct default value must be{}theempty dict.
All checking for
network_statemust check for a value of{}to mean "network_state not set or empty".Fix the test which looks for teaming configuration in EL10
to correctly look for the value in
network_state.Signed-off-by: Rich Megginson rmeggins@redhat.com