-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Support autoconnect_retries #737
feat: Support autoconnect_retries #737
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
===========================================
+ Coverage 20.40% 43.27% +22.87%
===========================================
Files 10 12 +2
Lines 1485 3110 +1625
Branches 436 0 -436
===========================================
+ Hits 303 1346 +1043
- Misses 1181 1764 +583
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
autoconnect_retries
[citest] |
71c3907
to
75809bc
Compare
[citest] |
There is no fine-grained control over the number of retries for automatically reconnecting a network connection in the role. This limitation can be problematic for certain use cases where extending the retry process is critical, particularly in environments with unstable networks. Introduce support for the `autoconnect_retries` property in nm provider of `network_connections` variable. This feature allows users to configure how many times NetworkManager will attempt to reconnect a connection after a autoconnect failure, providing more control over network stability and performance. Resolves: https://issues.redhat.com/browse/RHEL-61599 Signed-off-by: Wen Liang <liangwen12year@gmail.com>
75809bc
to
0bda39e
Compare
Ignore the ansible-test output for now. We had to change the collection min version to 2.15, but it looks like ansible-test is using 2.14. This handles the NM case - what about if you use |
#735 (comment), I suggested the user to try out the |
[citest] |
@spetrosi still failing - from the logs, looks like some issue with the scp with the ssh key? |
I saw this, fixed in linux-system-roles/tft-tests#52 |
[citest] |
5d73511
into
linux-system-roles:main
Enhancement: feat: Support
autoconnect_retries
Reason:
There is no fine-grained control over the number of retries for automatically reconnecting a network connection in the role. This limitation can be problematic for certain use cases where extending the retry process is critical, particularly in environments with unstable networks. Introduce support for the
autoconnect_retries
property in nm provider ofnetwork_connections
variable. This feature allows users to configure how many times NetworkManager will attempt to reconnect a connection after a autoconnect failure, providing more control over network stability and performance.Result:
Issue Tracker Tickets (Jira or BZ if any):