Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Support autoconnect_retries #737

Merged

Conversation

liangwen12year
Copy link
Collaborator

Enhancement: feat: Support autoconnect_retries

Reason:
There is no fine-grained control over the number of retries for automatically reconnecting a network connection in the role. This limitation can be problematic for certain use cases where extending the retry process is critical, particularly in environments with unstable networks. Introduce support for the autoconnect_retries property in nm provider of network_connections variable. This feature allows users to configure how many times NetworkManager will attempt to reconnect a connection after a autoconnect failure, providing more control over network stability and performance.

Result:

Issue Tracker Tickets (Jira or BZ if any):

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.27%. Comparing base (89d7148) to head (0bda39e).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
library/network_connections.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #737       +/-   ##
===========================================
+ Coverage   20.40%   43.27%   +22.87%     
===========================================
  Files          10       12        +2     
  Lines        1485     3110     +1625     
  Branches      436        0      -436     
===========================================
+ Hits          303     1346     +1043     
- Misses       1181     1764      +583     
+ Partials        1        0        -1     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangwen12year liangwen12year changed the title feat: Support autoconnect_retries feat: Support autoconnect_retries Oct 4, 2024
@liangwen12year
Copy link
Collaborator Author

[citest]

@liangwen12year
Copy link
Collaborator Author

[citest]

There is no fine-grained control over the number of retries for
automatically reconnecting a network connection in the role. This
limitation can be problematic for certain use cases where extending the
retry process is critical, particularly in environments with unstable
networks. Introduce support for the `autoconnect_retries` property in nm
provider of `network_connections` variable. This feature allows users to
configure how many times NetworkManager will attempt to reconnect a
connection after a autoconnect failure, providing more control over
network stability and performance.

Resolves: https://issues.redhat.com/browse/RHEL-61599

Signed-off-by: Wen Liang <liangwen12year@gmail.com>
@richm
Copy link
Contributor

richm commented Oct 4, 2024

Ignore the ansible-test output for now. We had to change the collection min version to 2.15, but it looks like ansible-test is using 2.14.

This handles the NM case - what about if you use network_state?

@liangwen12year
Copy link
Collaborator Author

Ignore the ansible-test output for now. We had to change the collection min version to 2.15, but it looks like ansible-test is using 2.14.

This handles the NM case - what about if you use network_state?

#735 (comment), I suggested the user to try out the network_state to see if that will help with the situation.

@spetrosi
Copy link
Collaborator

spetrosi commented Oct 7, 2024

[citest]

@richm
Copy link
Contributor

richm commented Oct 7, 2024

@spetrosi still failing - from the logs, looks like some issue with the scp with the ssh key?

@spetrosi
Copy link
Collaborator

spetrosi commented Oct 8, 2024

@spetrosi still failing - from the logs, looks like some issue with the scp with the ssh key?

I saw this, fixed in linux-system-roles/tft-tests#52

@spetrosi
Copy link
Collaborator

spetrosi commented Oct 8, 2024

[citest]

@liangwen12year liangwen12year merged commit 5d73511 into linux-system-roles:main Oct 8, 2024
23 of 31 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants