Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Add new board: Purism Librem Mini" #824

Closed
wants to merge 1 commit into from

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Sep 3, 2020

@MrChromebox
Copy link
Contributor

I don't see the sense in reverting a board addition just because of CI issues -- we certainly wouldn't drop any other existing board for that. Just means that fixing CI needs to be prioritized.

@flammit
Copy link
Collaborator

flammit commented Sep 3, 2020

I agree with @MrChromebox. If local builds work, then we should keep the board. It sounds like CI needs to be fixed to match real-world build conditions, which can be on any number of distros that should all build to the same byte-for-byte binary (how it was in the past).

@tlaurion
Copy link
Collaborator Author

tlaurion commented Sep 3, 2020

It sounds like CI needs to be fixed to match real-world build conditions, which can be on any number of distros that should all build to the same byte-for-byte binary (how it was in the past).

It is the same. We changed from musl-cross to musl-cross-make which is linked to current kernel reproducibility issue.

@MrChromebox I will close this PR and create another one, removing librem_mini from circleci

As always, your help in fixing gitlabci and circleci is more then welcome. They download specified docker images, then download build required tools and do what they are asked to do the same way it should happen locally. Please review.

@MrChromebox
Copy link
Contributor

so is it a docker issue then? I've never used docker in any capacity whatsoever

@tlaurion
Copy link
Collaborator Author

tlaurion commented Sep 3, 2020

so is it a docker issue then? I've never used docker in any capacity whatsoever

I will test later on on local docker image downloaded from the same source and test software deployed under CircleCI recipe. But this is not one of my priority for the moment, unfortunately.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants