Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: adjust the style of button #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FeiWang1119
Copy link

adjust the style of button

Log:

adjust the style of button

Log:
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#444
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

代码审查意见:

  1. 代码重复:在BoxPanel.qml文件中,BoxShadow组件的shadowBlurshadowOffsetY属性在多个Loader中重复设置,建议将这些属性提取为公共变量或函数,以减少代码重复。

  2. 注释使用:在BoxPanel.qml文件中,BoxShadow组件的shadowColor属性使用了注释掉的字符串值(如"red"),建议移除这些注释,或者使用适当的调试工具来代替。

  3. 颜色值:在FlowStyle.qml文件中,buttonbackground2common颜色值在normalhovered状态下相同,这可能是一个错误,应该检查这些颜色值是否应该不同。

  4. 透明度:在FlowStyle.qml文件中,dropShadow2pressed状态使用了"transparent",这可能会导致渲染问题,建议使用Qt.rgba(0, 0, 0, 0)来表示完全透明。

  5. 未使用的代码:在BoxPanel.qml文件中,BoxInsetShadow组件的第二个Loader块被注释掉了,如果这部分代码不再需要,建议删除以保持代码的整洁。

  6. 颜色值一致性:在FlowStyle.qml文件中,buttonbackground2common颜色值在normalhovered状态下相同,这可能是一个错误,应该检查这些颜色值是否应该不同。

  7. 未使用的属性:在ListView.qml文件中,dropShadowColor属性被替换为dropShadowColor0dropShadowColor1dropShadowColor2,但原始的dropShadowColor属性仍然存在,建议移除未使用的属性。

  8. 颜色值:在RecommandButton.qml文件中,Button组件的highlighted属性被替换为textColor属性,但原始的highlighted属性仍然存在,建议移除未使用的属性。

  9. 代码风格:在ButtonPanel.qml文件中,selectValue函数的调用方式不一致,建议统一使用相同的格式,以提高代码的可读性。

  10. 注释:在ButtonPanel.qml文件中,dropShadowColor属性的注释应该更新,以反映新的属性名称。

这些意见旨在提高代码的质量、可维护性和性能。在实际应用中,可能需要根据具体情况进行调整。

@FeiWang1119
Copy link
Author

image

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 2, 2025

TAG Bot

New tag: 5.7.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #447

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 9, 2025

TAG Bot

New tag: 5.7.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #452

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 14, 2025

TAG Bot

New tag: 5.7.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #456

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 23, 2025

TAG Bot

New tag: 5.7.9
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #457

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 13, 2025

TAG Bot

New tag: 5.7.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #459

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants