Fix crash when listing tests with groups being skipped #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'p.List()' function returns a list of results not tests, rename the variable to 'r' as it seems more appropriate. Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
This fixes an issue (linuxkit#45), where, if an entire group get's skipped `rtf list` would crash. This does not seem quite like the right solution and we should probably restructure the code considerably to *not* return a test object when just listing the tests... Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
|
Some of the tests fail. This is getting too ugly and I'll fix it better with |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rtf listfor some reason returns aResultobject which in turn references aTestobject. For skipped groups, there is notTestobject and the listing fails. This PR adds a fake/dummyTestto theResultof skipped groups when listing.Ideally we would not return a
Resultobject on listing the test...resolves #45