Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make it possible to disable the IP reflection #1684

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Make it possible to disable the IP reflection #1684

merged 1 commit into from
Mar 16, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Feb 21, 2023 •
edited
Loading

Description

This pr allows the Liqo users to disable the IP reflection. The local copy of the offloaded pods will not have an assigned IP, and the endpoint slice reflection is disabled by default.

Ref #1671

How Has This Been Tested?

  • locally on KinD with the reflection enabled
  • locally on KinD with the reflection disabled

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli mentioned this pull request Feb 21, 2023
Open
10 tasks
@aleoli
Copy link
Member Author

aleoli commented Feb 22, 2023

/build

@aleoli
Copy link
Member Author

aleoli commented Feb 22, 2023

/test

@aleoli aleoli added kind/feature hold Prevent bot merging labels Feb 22, 2023
@aleoli aleoli force-pushed the aol/disable-ip-reflection branch 2 times, most recently from fbe7c73 to 5c64113 Compare February 24, 2023 08:25
@aleoli aleoli force-pushed the aol/disable-ip-reflection branch from 5c64113 to 286b0ab Compare March 15, 2023 09:59
@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 15, 2023
@aleoli aleoli force-pushed the aol/disable-ip-reflection branch from 286b0ab to 22fb2cc Compare March 15, 2023 10:27
@aleoli
Copy link
Member Author

aleoli commented Mar 15, 2023

/test

@aleoli aleoli requested a review from cheina97 March 15, 2023 10:32
@aleoli aleoli removed the hold Prevent bot merging label Mar 15, 2023
@aleoli aleoli marked this pull request as ready for review March 15, 2023 10:32
@aleoli
Copy link
Member Author

aleoli commented Mar 16, 2023

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the aol/disable-ip-reflection branch from 22fb2cc to b8a23c8 Compare March 16, 2023 08:33
@aleoli
Copy link
Member Author

aleoli commented Mar 16, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 16, 2023
@adamjensenbot adamjensenbot merged commit c6ffbb2 into liqotech:master Mar 16, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 16, 2023
@p-linnane p-linnane mentioned this pull request Apr 14, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cheina97 cheina97

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleoli @adamjensenbot @cheina97