Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: fix HA replicas checks #2804

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 5, 2024

Description

This PR modifies tests for HA components. In particular:

  • lowered the replicas from 3 to 2
  • checker for ready pods now dynamically checks the expected number of pods depending on how HA was configured
  • fixed Eventually() statements in network_test.go
  • added test to check if exactly one gateway pod is Active
  • fixed a bug in the SmartMergeLabels and SmartMergeAnnotations functions

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 changed the title test: fix HA replicas tests test: fix HA replicas checks Nov 5, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 5, 2024

/test

@fra98 fra98 force-pushed the frt/ha-replicas-test branch from aaed7eb to 6756974 Compare November 5, 2024 14:06
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 5, 2024
@fra98
Copy link
Member Author

fra98 commented Nov 5, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Nov 5, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Nov 8, 2024

/test

2 similar comments
@fra98
Copy link
Member Author

fra98 commented Nov 8, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Nov 8, 2024

/test

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 13, 2024
@fra98 fra98 marked this pull request as draft November 13, 2024 09:57
@fra98
Copy link
Member Author

fra98 commented Nov 13, 2024

/test

1 similar comment
@fra98
Copy link
Member Author

fra98 commented Nov 13, 2024

/test

@fra98 fra98 force-pushed the frt/ha-replicas-test branch 2 times, most recently from 80a91bf to 3a316e3 Compare November 14, 2024 14:57
@fra98 fra98 force-pushed the frt/ha-replicas-test branch from 3a316e3 to 26275d9 Compare November 14, 2024 15:06
@fra98 fra98 marked this pull request as ready for review November 14, 2024 15:07
@fra98
Copy link
Member Author

fra98 commented Nov 14, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Nov 18, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 18, 2024
@adamjensenbot adamjensenbot merged commit f8312ec into liqotech:master Nov 18, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants