Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: peer command default network resources namespace #2846

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Dec 5, 2024

Description

This PR makes the peer command automatically default the namespaces used for network resources to the liqo tenant namespace, even if the user passes the --kubeconfig or --remote-kubeconfig args (or has the ns set in the kubeconfig).

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Dec 5, 2024
@fra98 fra98 force-pushed the frt/peer-default-tenant-ns branch 2 times, most recently from 5ec7124 to 0a87e35 Compare December 6, 2024 10:49
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 6, 2024
@fra98 fra98 marked this pull request as ready for review December 6, 2024 12:44
@fra98
Copy link
Member Author

fra98 commented Dec 6, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/peer-default-tenant-ns branch from 8becc31 to f9fe8b1 Compare December 6, 2024 15:02
@fra98
Copy link
Member Author

fra98 commented Dec 6, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 6, 2024
@adamjensenbot adamjensenbot merged commit a856f42 into liqotech:master Dec 6, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants