Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Liqoctl] network test exit error code #2865

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

cheina97
Copy link
Member

Description

This PR allows the liqoctl test network command to return an exit code different from 0 in case the command fails without the --fail-fast flag

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 added the fix Fixes a bug in the codebase. label Dec 11, 2024
@cheina97 cheina97 force-pushed the frc/liqoctltesterror branch from add4b24 to 63c98fe Compare December 11, 2024 15:40
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase

@fra98
Copy link
Member

fra98 commented Dec 12, 2024

/test

@cheina97
Copy link
Member Author

/rebase

@cheina97 cheina97 merged commit 9ee35be into liqotech:master Dec 12, 2024
9 checks passed
@cheina97 cheina97 deleted the frc/liqoctltesterror branch December 12, 2024 15:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix Fixes a bug in the codebase. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants