Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugs/fix 2487 allow contains whitespaces #2498

Merged

Conversation

JKamsker
Copy link
Collaborator

@JKamsker JKamsker commented Jun 6, 2024

Fixes #2487 and contains a minor perf improvement

@JKamsker JKamsker requested a review from pictos June 6, 2024 22:09
@pictos
Copy link
Member

pictos commented Jun 7, 2024

@JKamsker we do have a failing build, can you verify the reason?

@JKamsker
Copy link
Collaborator Author

JKamsker commented Jun 7, 2024

@JKamsker we do have a failing build, can you verify the reason?

Debug builds just fine, release doesnt.
Because: https://github.com/mbdavid/LiteDB/blob/610e530bb2d70be9718777dff0ebaba66a3d9cdd/LiteDB/Utils/Constants.cs#L7-L10
And CreateEngine in https://github.com/mbdavid/LiteDB/blob/fad6af353d86514faa90e46e3db1efb73369331e/LiteDB.Tests/Issues/Issue2487_Tests.cs#L22

Which is internal
https://github.com/mbdavid/LiteDB/blob/610e530bb2d70be9718777dff0ebaba66a3d9cdd/LiteDB/Client/Structures/ConnectionString.cs#L110

@pictos Do you think its safe to remove the #if DEBUG in Constants ? Otherwise we cant test release builds. I Have no idea whats the benefit of InternalsVisibleTo when you cant use it half of the time.

@JKamsker JKamsker requested a review from pictos June 11, 2024 21:26
@mbdavid mbdavid merged commit 3b7cc00 into litedb-org:master Jun 19, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect argument validation exception
4 participants