Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Addresses issue of upgrading from v4.x databases in LiteDB versions 5.0.18-5.0.20 #2499

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

jdtkw
Copy link

@jdtkw jdtkw commented Jun 7, 2024

Fixes #2494

Avoid using AesStream class when opening an older version of LiteDB database, as its imcompatible with the older versions.

@jdtkw jdtkw changed the title Avoid using AesStream class when opening an older version of LiteDB d… Addresses issue of upgrading from v4.x databases in LiteDB versions 5.0.18-5.0.20 Jun 7, 2024
@JKamsker
Copy link
Collaborator

JKamsker commented Jun 7, 2024

Can you add tests that show that the upgrade works with your changes?

Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR

LiteDB/Engine/Services/RebuildService.cs Outdated Show resolved Hide resolved
LiteDB/Engine/Disk/StreamFactory/FileStreamFactory.cs Outdated Show resolved Hide resolved
LiteDB/Engine/Disk/StreamFactory/FileStreamFactory.cs Outdated Show resolved Hide resolved
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR

Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button

@JKamsker
Copy link
Collaborator

JKamsker commented Jun 7, 2024

The code feels a bit odd to me but it works. I could add my tests if you allow additions by maintainers.

Copy link
Collaborator

@JKamsker JKamsker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdtkw
Copy link
Author

jdtkw commented Jun 10, 2024

The code feels a bit odd to me but it works. I could add my tests if you allow additions by maintainers.

Yeah, I went for a fix for the problem that would limit any form of adverse interaction with other code / use cases. Not 100% happy with it myself, but feel it's not going to affect normal operation once it has upgraded to to the latest format.

@jdtkw
Copy link
Author

jdtkw commented Jun 10, 2024

Can you add tests that show that the upgrade works with your changes?

Thanks for doing this.

@jdtkw jdtkw requested a review from pictos June 10, 2024 02:24
@jdtkw
Copy link
Author

jdtkw commented Jun 12, 2024

Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR

Hi @pictos - think @JKamsker already responded to the breaking change issue. I've fixed the tabs vs. spaces problem. Please let me know what else needs fixing.

Do we have a timeline on when this could be rolled into a release?

@pictos pictos merged commit daf2c2c into litedb-org:master Jun 12, 2024
1 check passed
@pictos
Copy link
Member

pictos commented Jun 12, 2024

@jdtkw we will see other PRs to merge and then schedule a SR version, that should not take so long.

Thanks for your contribution

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Upgrading from Version 4 Throws LiteException: File is not encrypted as of Version 5.0.18
3 participants