-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Addresses issue of upgrading from v4.x databases in LiteDB versions 5.0.18-5.0.20 #2499
Conversation
Can you add tests that show that the upgrade works with your changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button
The code feels a bit odd to me but it works. I could add my tests if you allow additions by maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Yeah, I went for a fix for the problem that would limit any form of adverse interaction with other code / use cases. Not 100% happy with it myself, but feel it's not going to affect normal operation once it has upgraded to to the latest format. |
Thanks for doing this. |
Hi @pictos - think @JKamsker already responded to the breaking change issue. I've fixed the tabs vs. spaces problem. Please let me know what else needs fixing. Do we have a timeline on when this could be rolled into a release? |
@jdtkw we will see other PRs to merge and then schedule a SR version, that should not take so long. Thanks for your contribution |
Fixes #2494
Avoid using AesStream class when opening an older version of LiteDB database, as its imcompatible with the older versions.