Fix race condition in #2536 #2537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a race condition in BsonMapper, caused by a fix to a different issue in litedb-org#2493. It seems like the current approach of checking the dictionary twice is deliberate. That said, I don't believe reading from a dictionary that may be in the process of being updated is actually safe to begin with.
|
Closing in favor of #2538 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition in BsonMapper (#2536), caused by a fix to a different issue in #2493.
It seems like the current approach of checking the dictionary twice is deliberate, likely for performance reasons. That said, I don't believe reading from a dictionary that may be in the process of being updated is actually safe to begin with.
If this is unacceptable perf-wise I believe the locking must be swapped with a proper read-write lock.