Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

emubd: fix MSVC compilation #384

Closed
wants to merge 1 commit into from
Closed

Conversation

Mixaill
Copy link
Contributor

@Mixaill Mixaill commented Feb 26, 2020

fixes emubd compilation with pure MSVC compiler.

@geky
Copy link
Member

geky commented Feb 26, 2020

Hi @Mixaill, thanks for the PR!

The emubd layer is actually changing significantly here:
#372

Though I'm not sure how #372 would effect MSVC.

@geky
Copy link
Member

geky commented Apr 9, 2020

Thanks for the PR. But I'm going to go ahead and close this as the bd layer was rewritten in v2.2. It no longer calls mkdir, so I'm not sure what changes need to be made for MSVC support.

@geky geky closed this Apr 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants