Fixes and tests for lists #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2024 16:55
lib/kino/explorer.ex
Outdated
| defp compute_summaries?(series) do | ||
| # hacky way to provide backward compatibility for {:list, numeric} error | ||
| # https://github.com/elixir-explorer/explorer/issues/787 | ||
| exp_ver_0_7_2_gte? = Explorer.Shared.dtypes() |> Enum.member?({:s, 8}) |
There was a problem hiding this comment.
As far as I understand it's actually exp_ver_0_7_2_gt?, because {:s, 8} is only on main, right?
Also, let's add a TODO to remove the check once we require only explorer v0.8.
jonatanklosko
approved these changes
Jan 5, 2024
ghost
merged commit
This pull request was closed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.