Add support for agent dispatch management #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biglittlebigben
commented
Aug 8, 2024
cmd/lk/agent_dispatch.go
Outdated
| var ( | ||
| AgentDispatchCommands = []*cli.Command{ | ||
| { | ||
| Name: "agentdispatch", |
There was a problem hiding this comment.
We should probably discuss the proper name/command hierarchy here, since agentdispatch may not be clear
There was a problem hiding this comment.
I see nothing wrong with making dispatch a subcommand of agent command:
lk agent dispatch create --room my_room --agent-name bot
rektdeckard
approved these changes
Aug 8, 2024
cmd/lk/agent_dispatch.go
Outdated
| Commands: []*cli.Command{ | ||
| { | ||
| Name: "create", | ||
| Usage: "Create an agent dispatches", |
There was a problem hiding this comment.
Suggested change
| Usage: "Create an agent dispatches", | |
| Usage: "Create an agent dispatch", |
cmd/lk/agent_dispatch.go
Outdated
Comment on lines
41
to
57
| Flags: []cli.Flag{ | ||
| &cli.StringFlag{ | ||
| Name: "room", | ||
| Usage: "`Name` of the room to create the dispatch in", | ||
| Required: true, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "agent-name", | ||
| Usage: "`Agent Name` to dispatch the job to", | ||
| Required: false, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "metadata", | ||
| Usage: "`Metadata` to pass to the agent workers", | ||
| Required: false, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
nit: SHOUTING_CASE for arg names
cmd/lk/agent_dispatch.go
Outdated
| var ( | ||
| AgentDispatchCommands = []*cli.Command{ | ||
| { | ||
| Name: "agentdispatch", |
There was a problem hiding this comment.
I see nothing wrong with making dispatch a subcommand of agent command:
lk agent dispatch create --room my_room --agent-name bot
paulwe
approved these changes
Aug 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for agent dispatch management through integration with the agent dispatch service.