Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add pydantic support to rtc.VideoFrame & rtc.AudioFrame #348

Merged
merged 8 commits into from
Jan 24, 2025
Merged

add pydantic support to rtc.VideoFrame & rtc.AudioFrame #348

merged 8 commits into from
Jan 24, 2025

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Jan 17, 2025 •
edited
Loading

  • this package still doesn't depend on pydantic
  • data is serialized in b64

@theomonnom theomonnom requested a review from a team January 17, 2025 19:21
@theomonnom theomonnom changed the title add pydantic support add pydantic support to rtc.VideoFrame & rtc.AudioFrame Jan 17, 2025
davidzhao
davidzhao approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, but is the rust lib update intentional?

@theomonnom theomonnom merged commit d9aac49 into main Jan 24, 2025
10 checks passed
@theomonnom theomonnom deleted the theo/pydantic-support branch January 24, 2025 12:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theomonnom @davidzhao