Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove need for hash_extract_if feature and support non-nightly rust compiler #134

Closed
simlay opened this issue Oct 1, 2024 · 1 comment
Closed

Remove need for hash_extract_if feature and support non-nightly rust compiler #134

simlay opened this issue Oct 1, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@simlay
Copy link
Contributor

simlay commented Oct 1, 2024

In #130, the hash_extract_if unstable language feature was added.

This project supports compiling to a number of Tier 3 rust targets which is requires build-std so we still need to use nightly to compile for watchOS, tvOS and visionOS.

Let's add a rust-stable CI check and remove the call to extract_if on HashMap.
@simlay simlay added the good first issue Good for newcomers label Oct 10, 2024
@mobile-bungalow mobile-bungalow mentioned this issue Oct 22, 2024
Merged
simlay pushed a commit that referenced this issue Oct 23, 2024
@mobile-bungalow
Remove nightly features #134 (#138)
581414b 
* version bump
* remove dep
* remove async closure dep (unused)
* CI fiddling
@simlay
Copy link
Contributor Author

simlay commented Oct 23, 2024

Closed in #138.

@simlay simlay closed this as completed Oct 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
LiveViewNative Core
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simlay