Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[SMT] Add constant boolean operation #6825

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

maerhart
Copy link
Member

No description provided.

Copy link
Contributor

@TaoBi22 TaoBi22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

let arguments = (ins BoolAttr:$value);
let results = (outs BoolType:$result);
let assemblyFormat = "$value attr-dict";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably at some point want a builder that just take a boolean, but maybe that's already generated (?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same thought, so I checked, and it's actually already auto-generated 👍

@maerhart maerhart force-pushed the maerhart-smt-boolean-ops branch from e579345 to 46a99f9 Compare March 17, 2024 16:10
Base automatically changed from maerhart-smt-boolean-ops to main March 17, 2024 16:33
@maerhart maerhart force-pushed the maerhart-smt-bool-const branch from 79efa20 to 6bef9ed Compare March 17, 2024 17:23
@maerhart maerhart merged commit c406400 into main Mar 17, 2024
4 checks passed
@maerhart maerhart deleted the maerhart-smt-bool-const branch March 17, 2024 17:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants