[FIRRTL][Dedup] Reduce size of integer data hashed. #7469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't always zext to size_t. Use smaller integer sizes for ValueId and add to hash together.
dtzSiFive
force-pushed
the
feature/dedup-less-bytes-to-hash
branch
from
8fe893a to
0512d22
Compare
dtzSiFive
commented
Aug 8, 2024
|
|
||
| void update(size_t value) { | ||
| /// Hash value as array of bytes. | ||
| template <typename T> |
There was a problem hiding this comment.
FWIW:
If I could confidently enable_if this to ensure it doesn't get used with things that have possibly unset padding or short reads or something I would but instead I just wrap it for types that are definitely safe and cover our needs.
dtzSiFive
added a commit
that referenced
this pull request
Aug 8, 2024
Revisit with unambiguous methods. This reverts commit da2428a.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't always zext to size_t.
Use smaller integer sizes for ValueId and add to hash together.
Small performance win.