Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Verif] Add ignore attribute to formal #7719

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Conversation

leonardt
Copy link
Contributor

By default, circt-test will not include "ignored" verif.formal ops in the output but has an option --include-ignored to emit them.

By default, `circt-test` will not include "ignored" verif.formal ops
in the output but has an option `--include-ignored` to emit them.
Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com>
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and elegant 🙂 LGTM

test/circt-test/basic.mlir Outdated Show resolved Hide resolved
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm a bit worried about using discardable attribute for this purpose but I think it's fine as an initial iteration.

@leonardt
Copy link
Contributor Author

If anyone wants to give this a final review: I needed to resolve merge conflicts with Fabian's sby runner changes and added logic to execute to handle ignored tests

@leonardt leonardt merged commit 2bd44c8 into main Oct 31, 2024
4 checks passed
@leonardt leonardt deleted the lenny/verif-formal-ignore branch October 31, 2024 23:25
jiahanxie353 pushed a commit to jiahanxie353/circt that referenced this pull request Nov 17, 2024
By default, `circt-test` will not include "ignored" verif.formal ops
in the output list but has an option `--list-ignored` to emit them.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants