-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Verif] Add ignore attribute to formal #7719
Conversation
By default, `circt-test` will not include "ignored" verif.formal ops in the output but has an option `--include-ignored` to emit them.
Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and elegant 🙂 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm a bit worried about using discardable attribute for this purpose but I think it's fine as an initial iteration.
If anyone wants to give this a final review: I needed to resolve merge conflicts with Fabian's |
By default, `circt-test` will not include "ignored" verif.formal ops in the output list but has an option `--list-ignored` to emit them.
By default,
circt-test
will not include "ignored" verif.formal ops in the output but has an option--include-ignored
to emit them.