[Verif][NFC] Use auto-generated constructors for all passes #7754
+25
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the `let constructor` line from the Verif pass definitions. This causes TableGen to automatically generate the constructors for these passes, and also handle pass options if we ever decide to add them. This requires adding a `...Pass` to the end of each pass def to produce a constructor name of the form `create...Pass()`.
seldridge
approved these changes
Oct 31, 2024
| @@ -1,4 +1,4 @@ | |||
| //===-- Passes.td - Verif pass definition file ----------------*- tablegen -*-===// | |||
| //===-- Passes.td - Verif pass definition file -------------*- tablegen -*-===// | |||
fabianschuiki
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the
let constructorline from the Verif pass definitions. This causes TableGen to automatically generate the constructors for these passes, and also handle pass options if we ever decide to add them.This requires adding a
...Passto the end of each pass def to produce a constructor name of the formcreate...Pass().