[firtool] Add an option to emit HW MLIR into file #8169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
reviewed
Feb 1, 2025
tools/firtool/firtool.cpp
Outdated
| @@ -456,6 +494,11 @@ static LogicalResult processBuffer( | |||
| if (failed(firtool::populateHWToBTOR2(pm, firtoolOptions, | |||
| (*outputFile)->os()))) | |||
| return failure(); | |||
|
|
|||
| // If requseted, emit the HW IR to hwOutFile. | |||
mikeurbach
reviewed
Feb 1, 2025
fabianschuiki
approved these changes
Feb 1, 2025
|
Is possible for adding a c-api for this? |
It's a bit tricky to do that because the option is not pipeline option strictly speaking (The option is not added to FirtoolOption intentionally). In CAPI you can manually dump IR after HW lowering if you necessary, and I think it's more flexible. So let me first merge the PR and add CAPI if it turned it's really necessary. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
-output-hw-mliroption to firtool which emits HW IR into file in a similar way to-output-final-mlir.This PR adds
DumpIRpass to simplify the emission. It's currently not exposed to other tool as it's very specific to firtool pipeline (actually the pass indirectly uses cl options defined in firtool.cpp)