[circt-verilog-lsp] Add inlay hints support for Verilog LSP server #8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds inlay hint support to the Verilog LSP server. It currently supports two ways of displaying inlay hints: 1. Built-in inlay hints for function calls and module instantiations, showing port types and directions (in/out/inout). 2. User-provided inlay hints through a custom LSP extension method "verilog/putUserProvidedInlayHints", allowing clients to add contextual information to Verilog symbols. The implementation includes: - Protocol extensions for user-provided inlay hints - Visitor pattern for traversing the AST to find hint locations - Support for refreshing hints when they are updated
uenoku
commented
Mar 6, 2025
| @@ -521,14 +652,20 @@ struct VerilogIndexer : slang::ast::ASTVisitor<VerilogIndexer, true, true> { | |||
| isDefinition); | |||
| } | |||
|
|
|||
| // Handle references to the left-hand side of a parent assignment. | |||
| void visit(const slang::ast::LValueReferenceExpression &expr) { | |||
| // Handle named values, such as references to declared variables. | |||
There was a problem hiding this comment.
This change must be moved to #8280.
uenoku
commented
Mar 7, 2025
| "text":"module test(); wire foo; reg bar; endmodule" | ||
| }}} | ||
| // ----- | ||
| // Find definition of `out` |
There was a problem hiding this comment.
Suggested change
| // Find definition of `out` |
uenoku
commented
Mar 7, 2025
| @@ -241,7 +274,7 @@ export class CIRCTContext implements vscode.Disposable { | |||
| }; | |||
|
|
|||
| // Configure file patterns relative to the workspace folder. | |||
| let filePattern: vscode.GlobPattern = "**/*." + languageName; | |||
| let filePattern: vscode.GlobPattern = "**/*.(sv|v)"; | |||
There was a problem hiding this comment.
This must be moved to vscode PR
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds inlay hint support to the Verilog LSP server. It currently supports two ways of displaying inlay hints:
Built-in inlay hints for function calls and module instantiations, showing port types and directions (in/out/inout).
User-provided inlay hints through a custom LSP extension method "verilog/putUserProvidedInlayHints", allowing clients to add contextual information to Verilog symbols.
The implementation includes: