Skip to content

[libc++] Replace uses of __libcpp_ctz by __countr_zero #131179

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ldionne opened this issue Mar 13, 2025 · 0 comments · Fixed by #133920
Closed

[libc++] Replace uses of __libcpp_ctz by __countr_zero #131179

ldionne opened this issue Mar 13, 2025 · 0 comments · Fixed by #133920
Assignees
@winner245
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@ldionne
Copy link
Member

ldionne commented Mar 13, 2025 •
edited
Loading

For a follow-up patch, we should replace uses of __libcpp_ctz in the codebase by calls to __countr_zero (there's only a few). This will eventually allow us to clean up __libcpp_ctz altogether.

Originally posted by @ldionne in #122641 (comment)
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 13, 2025
@PaulXiCao PaulXiCao mentioned this issue Mar 23, 2025
Closed
@winner245 winner245 mentioned this issue Apr 1, 2025
Merged
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this issue May 6, 2025
@winner245 @IanWood1
[libc++] Replace __libcpp_{ctz, clz} with __builtin_{ctzg, clzg} (llv…
293a7d7 
…m#133920)

`__libcpp_{ctz, clz}` were previously used as fallbacks for `__builtin_{ctzg, clzg}` to ensure compatibility with older compilers (Clang 18 and earlier), as `__builtin_{ctzg, clzg}` became available in Clang 19. Now that support for Clang 18 has been officially dropped in llvm#130142, we can now safely  replace all instances of `__libcpp_{ctz, clz}` with `__count{l,r}_zero` (which internally call `__builtin_{ctzg, clzg}` and eliminate the fallback logic.

Closes llvm#131179.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this issue May 6, 2025
@winner245 @IanWood1
[libc++] Replace __libcpp_{ctz, clz} with __builtin_{ctzg, clzg} (llv…
df3b550 
…m#133920)

`__libcpp_{ctz, clz}` were previously used as fallbacks for `__builtin_{ctzg, clzg}` to ensure compatibility with older compilers (Clang 18 and earlier), as `__builtin_{ctzg, clzg}` became available in Clang 19. Now that support for Clang 18 has been officially dropped in llvm#130142, we can now safely  replace all instances of `__libcpp_{ctz, clz}` with `__count{l,r}_zero` (which internally call `__builtin_{ctzg, clzg}` and eliminate the fallback logic.

Closes llvm#131179.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this issue May 6, 2025
@winner245 @IanWood1
[libc++] Replace __libcpp_{ctz, clz} with __builtin_{ctzg, clzg} (llv…
f827de6 
…m#133920)

`__libcpp_{ctz, clz}` were previously used as fallbacks for `__builtin_{ctzg, clzg}` to ensure compatibility with older compilers (Clang 18 and earlier), as `__builtin_{ctzg, clzg}` became available in Clang 19. Now that support for Clang 18 has been officially dropped in llvm#130142, we can now safely  replace all instances of `__libcpp_{ctz, clz}` with `__count{l,r}_zero` (which internally call `__builtin_{ctzg, clzg}` and eliminate the fallback logic.

Closes llvm#131179.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@winner245 winner245

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
3 participants
@ldionne @winner245 @llvmbot