Skip to content

[libc++] Modules tests keep failing on the release/18.x branch #85242

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ldionne opened this issue Mar 14, 2024 · 2 comments
Closed

[libc++] Modules tests keep failing on the release/18.x branch #85242

ldionne opened this issue Mar 14, 2024 · 2 comments
Assignees
@ldionne
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport release:cherry-pick-failed test-suite
Milestone
LLVM 18.X Release

Comments

@ldionne
Copy link
Member

ldionne commented Mar 14, 2024

We should disable the since it borks the rest of the CI.
@ldionne ldionne added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 14, 2024
@ldionne ldionne added this to the LLVM 18.X Release milestone Mar 14, 2024
@ldionne ldionne self-assigned this Mar 14, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Mar 14, 2024
@ldionne
Copy link
Member Author

ldionne commented Mar 14, 2024

/cherry-pick 0bbada9

@llvmbot
Copy link
Member

llvmbot commented Mar 14, 2024

Failed to cherry-pick: 0bbada9

https://github.com/llvm/llvm-project/actions/runs/8283300691

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@ldionne ldionne mentioned this issue Mar 14, 2024
Closed
ldionne added a commit to ldionne/llvm-project that referenced this issue Mar 14, 2024
@ldionne
[libc++] Use clang-tidy version that matches the compiler we use in t…
810c55d 
…he CI

This works around ODR violations in the clang-tidy plugin we use to
perform the modules tests.

Fixes llvm#85242
@ldionne ldionne mentioned this issue Mar 14, 2024
Merged
tstellar pushed a commit that referenced this issue Mar 16, 2024
@ldionne
[libc++] Use clang-tidy version that matches the compiler we use in t…
3a06861 
…he CI (#85305)

This works around ODR violations in the clang-tidy plugin we use to
perform the modules tests.

Fixes #85242
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Mar 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ldionne ldionne

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport release:cherry-pick-failed test-suite
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 18.X Release
Development

No branches or pull requests
4 participants
@tstellar @ldionne @EugeneZelenko @llvmbot