-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[MSP430] Default to unsigned char #115964
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[MSP430] Default to unsigned char #115964
Conversation
Created using spr 1.3.6-beta.1
@llvm/pr-subscribers-backend-msp430 @llvm/pr-subscribers-clang Author: Alexander Richardson (arichardson) ChangesThis matches the ABI document at https://www.ti.com/lit/pdf/slaa534 as Partially fixes #115957. Full diff: https://github.com/llvm/llvm-project/pull/115964.diff 2 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 0952262c360185..75379e0a00b981 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -1341,6 +1341,7 @@ static bool isSignedCharDefault(const llvm::Triple &Triple) {
return false;
case llvm::Triple::hexagon:
+ case llvm::Triple::msp430:
case llvm::Triple::ppcle:
case llvm::Triple::ppc64le:
case llvm::Triple::riscv32:
diff --git a/clang/test/Driver/msp430-char.c b/clang/test/Driver/msp430-char.c
new file mode 100644
index 00000000000000..4f62eb167e1c84
--- /dev/null
+++ b/clang/test/Driver/msp430-char.c
@@ -0,0 +1,5 @@
+/// Check that char is unsigned by default.
+// RUN: %clang -### %s --target=msp430 -c 2>&1
+// RUN: %clang -### %s --target=msp430 -c 2>&1 | FileCheck%s
+// CHECK: "-cc1" "-triple" "msp430"
+// CHECK-SAME: "-fno-signed-char"
|
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This matches GCC. Partially addresses llvm#115964 Pull Request: llvm#115967
This matches GCC. Partially addresses llvm#115964 Pull Request: llvm#115967
Update comments and sort target_arch in c_char_definition Follow-up to rust-lang#132975. - Clang's wrong default on MSP430 has been fixed in llvm/llvm-project#115964, and will be included in LLVM 20, which will be used soon. - Add a reference on Xtensa's default (from rust-lang#132975 (comment)). - Fix link for Windows's default. - Add a link to the discussion on L4Re (rust-lang#132975 (comment)) - Sort `target_arch`. (now match with `target_arch`s in comments) r? `@tgross35`
Rollup merge of rust-lang#136173 - taiki-e:c-char, r=tgross35 Update comments and sort target_arch in c_char_definition Follow-up to rust-lang#132975. - Clang's wrong default on MSP430 has been fixed in llvm/llvm-project#115964, and will be included in LLVM 20, which will be used soon. - Add a reference on Xtensa's default (from rust-lang#132975 (comment)). - Fix link for Windows's default. - Add a link to the discussion on L4Re (rust-lang#132975 (comment)) - Sort `target_arch`. (now match with `target_arch`s in comments) r? `@tgross35`
Update comments and sort target_arch in c_char_definition Follow-up to rust-lang#132975. - Clang's wrong default on MSP430 has been fixed in llvm/llvm-project#115964, and will be included in LLVM 20, which will be used soon. - Add a reference on Xtensa's default (from rust-lang#132975 (comment)). - Fix link for Windows's default. - Add a link to the discussion on L4Re (rust-lang#132975 (comment)) - Sort `target_arch`. (now match with `target_arch`s in comments) r? `@tgross35`
This matches the ABI document at https://www.ti.com/lit/pdf/slaa534 as
well as the GCC implementation.
Partially fixes #115957.