Skip to content

Conversation

svkeerthy
Copy link
Contributor

No description provided.

Copy link
Contributor Author

svkeerthy commented Aug 11, 2025

@svkeerthy svkeerthy marked this pull request as ready for review August 12, 2025 00:15
@llvmbot llvmbot added mlgo llvm:analysis Includes value tracking, cost tables and constant folding labels Aug 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 12, 2025

@llvm/pr-subscribers-llvm-analysis

@llvm/pr-subscribers-mlgo

Author: S. VenkataKeerthy (svkeerthy)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/153094.diff

1 Files Affected:

  • (modified) llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json (+1)
diff --git a/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json b/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json
index bb97a491dfe8a..fcc1344ada314 100644
--- a/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json
+++ b/llvm/test/Analysis/IR2Vec/Inputs/dummy_3D_nonzero_type_vocab.json
@@ -47,6 +47,7 @@
         "FPTrunc": [0, 0, 0],
         "FPExt": [0, 0, 0],
         "PtrToInt": [0, 0, 0],
+        "PtrToAddr": [0, 0, 0],
         "IntToPtr": [0, 0, 0],
         "BitCast": [0, 0, 0],
         "AddrSpaceCast": [0, 0, 0],

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't missed. It's new (patch landed last week I think).

Either way, LGTM.

Copy link
Contributor Author

Yes. The patch added "PtrToAddr" in all the other vocab files but this.

@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-merging_ir2vec_categories branch from 44c5895 to de8480b Compare August 25, 2025 22:59
@svkeerthy svkeerthy force-pushed the users/svkeerthy/08-11-_nfc_ir2vec_add_missed_ptrtoaddr_in_vocab_for_tests branch from 265222b to 8ce3c84 Compare August 25, 2025 22:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
llvm:analysis Includes value tracking, cost tables and constant folding mlgo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants