Skip to content

Conversation

danilaml
Copy link
Collaborator

Avoid false positives by requiring space after /branch command so the action won't trigger on diffs that include filenames like .../BranchProbabilityInfo.cpp.

Avoid false positives by requiring space after `/branch` command so the action won't trigger on diffs that include filenames like `.../BranchProbabilityInfo.cpp`.
@llvmbot
Copy link
Member

llvmbot commented Sep 19, 2023

@llvm/pr-subscribers-github-workflow

Changes

Avoid false positives by requiring space after /branch command so the action won't trigger on diffs that include filenames like .../BranchProbabilityInfo.cpp.


Full diff: https://github.com/llvm/llvm-project/pull/66781.diff

1 Files Affected:

  • (modified) .github/workflows/issue-release-workflow.yml (+1-1)
diff --git a/.github/workflows/issue-release-workflow.yml b/.github/workflows/issue-release-workflow.yml
index bd6d09cc65e0857..b09ef6555fa9017 100644
--- a/.github/workflows/issue-release-workflow.yml
+++ b/.github/workflows/issue-release-workflow.yml
@@ -70,7 +70,7 @@ jobs:
     if: >-
       (github.repository == 'llvm/llvm-project') &&
       !startswith(github.event.comment.body, '<!--IGNORE-->') &&
-      contains(github.event.comment.body, '/branch')
+      contains(github.event.comment.body, '/branch ')
 
     steps:
       - name: Fetch LLVM sources

@llvmbot
Copy link
Member

llvmbot commented Sep 19, 2023

@llvm/pr-subscribers-github-workflow

Changes

Avoid false positives by requiring space after /branch command so the action won't trigger on diffs that include filenames like .../BranchProbabilityInfo.cpp.


Full diff: https://github.com/llvm/llvm-project/pull/66781.diff

1 Files Affected:

  • (modified) .github/workflows/issue-release-workflow.yml (+1-1)
diff --git a/.github/workflows/issue-release-workflow.yml b/.github/workflows/issue-release-workflow.yml
index bd6d09cc65e0857..b09ef6555fa9017 100644
--- a/.github/workflows/issue-release-workflow.yml
+++ b/.github/workflows/issue-release-workflow.yml
@@ -70,7 +70,7 @@ jobs:
    if: >-
      (github.repository == 'llvm/llvm-project') &&
      !startswith(github.event.comment.body, '<!--IGNORE-->') &&
-      contains(github.event.comment.body, '/branch')
+      contains(github.event.comment.body, '/branch ')

    steps:
      - name: Fetch LLVM sources

Error: Command failed due to missing milestone.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants