Skip to content

[mlir][Transform] Provide a minimal set of utils that allow implementing a simple transform dialect interpreter pass #68330

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

[mlir][Transform] Provide a minimal set of utils that allow implementing a simple transform dialect interpreter pass #68330

merged 1 commit into from
Oct 6, 2023

Conversation

nicolasvasilache
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the mlir label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@nicolasvasilache nicolasvasilache force-pushed the flush-simplify-transforms-2 branch 3 times, most recently from 87a63e8 to 94553f9 Compare October 5, 2023 17:35
ftynse
ftynse reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@ftynse ftynse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update InterpreterPassBase to use these and avoid duplication?

@nicolasvasilache nicolasvasilache force-pushed the flush-simplify-transforms-2 branch 2 times, most recently from 4aa18c7 to 3ed8d51 Compare October 6, 2023 09:22
@nicolasvasilache
Copy link
Contributor Author

Could we update InterpreterPassBase to use these and avoid duplication?

Discussed this offline, it seems quite simpler to start a new interpreter pass takes advantage of more recent transform.named_sequence availability and gradually port tests and behaviors that we want to continue supporting.

@nicolasvasilache nicolasvasilache force-pushed the flush-simplify-transforms-2 branch from 3ed8d51 to 45731c5 Compare October 6, 2023 09:39
@nicolasvasilache nicolasvasilache force-pushed the flush-simplify-transforms-2 branch 2 times, most recently from 46621a3 to 883b4d1 Compare October 6, 2023 10:59
@nicolasvasilache
[mlir][Transform] Provide a minimal set of utils that allow implement…
cdfa540 
…ing a simple transform dialect interpreter pass
@nicolasvasilache nicolasvasilache force-pushed the flush-simplify-transforms-2 branch from 883b4d1 to cdfa540 Compare October 6, 2023 12:07
@nicolasvasilache nicolasvasilache merged commit ef8c26b into llvm:main Oct 6, 2023
@nicolasvasilache nicolasvasilache deleted the flush-simplify-transforms-2 branch October 6, 2023 12:11
@stepthomas stepthomas mentioned this pull request Oct 10, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ftynse ftynse ftynse approved these changes

Assignees
No one assigned
Labels
mlir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasvasilache @ftynse @llvmbot