[gitattributes] Don't mark all llvm-rc test Inputs as binary #68583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows tooling to properly show diffs for files in the llvm/test/tools/llvm-rc/Inputs directory. Keep the actual icon/cursor/bitmap files marked as binary.
mstorsjo
added
llvm-tools
|
@llvm/pr-subscribers-platform-windows ChangesThis allows tooling to properly show diffs for files in the llvm/test/tools/llvm-rc/Inputs directory. Keep the actual icon/cursor/bitmap files marked as binary. Full diff: https://github.com/llvm/llvm-project/pull/68583.diff 1 Files Affected:
diff --git a/llvm/.gitattributes b/llvm/.gitattributes
index fe68b096c31f231..5f0d9990b6b5880 100644
--- a/llvm/.gitattributes
+++ b/llvm/.gitattributes
@@ -11,7 +11,9 @@ test/tools/dsymutil/Inputs/*.swiftmodule binary
test/tools/llvm-ar/Inputs/*.lib binary
test/tools/llvm-ar/Inputs/*.a binary
test/tools/llvm-objdump/Inputs/*.a binary
-test/tools/llvm-rc/Inputs/* binary
+test/tools/llvm-rc/Inputs/*.bmp binary
+test/tools/llvm-rc/Inputs/*.cur binary
+test/tools/llvm-rc/Inputs/*.ico binary
test/tools/llvm-strings/Inputs/numbers binary
test/MC/AsmParser/incbin_abcd binary
test/YAMLParser/spec-09-02.test binary
|
$ ls test/tools/llvm-rc/Inputs/ -1 | cut -d . -f 2 | sort -u
bmp
cur
html
ico
nested/
rcThis patch makes html and rc files visible, LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tooling to properly show diffs for files in the llvm/test/tools/llvm-rc/Inputs directory.
Keep the actual icon/cursor/bitmap files marked as binary.