Unbreak *tf builtins for hexfloat #82208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works with our hexfloat and ieee builds on z/os. Thanks! |
This was referenced Feb 21, 2024
|
Alex, I discovered that our code I tried your PR on had a diff that was needed to get the code to compile. Our builds are actually still failing with just this PR. Sorry I missed that. I made the change in #82789. |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 25, 2024
This re-lands cc0065a in a way that keeps existing targets working. --------- Original commit message: llvm#68132 ended up removing __multc3 & __divtc3 from compiler-rt library builds that have QUAD_PRECISION but not TF_MODE due to missing int128 support. I added support for QUAD_PRECISION to use the native hex float long double representation. --------- Co-authored-by: Sean Perry <perry@ca.ibm.com> (cherry picked from commit 99c457d)
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Mar 13, 2024
This re-lands cc0065a in a way that keeps existing targets working. --------- Original commit message: llvm#68132 ended up removing __multc3 & __divtc3 from compiler-rt library builds that have QUAD_PRECISION but not TF_MODE due to missing int128 support. I added support for QUAD_PRECISION to use the native hex float long double representation. --------- Co-authored-by: Sean Perry <perry@ca.ibm.com> (cherry picked from commit 99c457d)
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #77981 with an additional fix on top that should unbreak PPC64. It took me a while to get back to this but I believe this change fixes it.
I am still getting failures for PPC32 but it's likely that this is due to my QEMU-user setup since those tests also failed without this patchset.
@perry-ca could you please test if this fixes the issue you reported?