[OpenMP] fix endianness dependent definitions in OMP headers for MSVC #84540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
added 2 commits
March 8, 2024 11:26
xingxue-ibm
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
LGTM, thanks for fixing the issue!
There are also 3 LIT test cases checking the same condition. It will be great if you could fix them while you are on it. Thanks!
openmp/runtime/test> grep -r __BYTE_ORDER__ *
tasking/bug_nested_proxy_task.c:#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
tasking/bug_proxy_task_dep_waiting.c:#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
tasking/hidden_helper_task/common.h:#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
natgla
approved these changes
Mar 8, 2024
|
added the test fixes |
xingxue-ibm
approved these changes
Mar 8, 2024
vadikp-intel
changed the title
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Mar 10, 2024
…llvm#84540) MSVC does not define __BYTE_ORDER__ making the check for BigEndian erroneously evaluate to true and breaking the struct definitions in MSVC compiled builds correspondingly. The fix adds an additional check for whether __BYTE_ORDER__ is defined by the compiler to fix these. --------- Co-authored-by: Vadim Paretsky <b-vadipa@microsoft.com> (cherry picked from commit 110141b)
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Mar 11, 2024
…llvm#84540) MSVC does not define __BYTE_ORDER__ making the check for BigEndian erroneously evaluate to true and breaking the struct definitions in MSVC compiled builds correspondingly. The fix adds an additional check for whether __BYTE_ORDER__ is defined by the compiler to fix these. --------- Co-authored-by: Vadim Paretsky <b-vadipa@microsoft.com> (cherry picked from commit 110141b)
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC does not define BYTE_ORDER making the check for BigEndian erroneously evaluate to true and breaking the struct definitions in MSVC compiled builds correspondingly. The fix adds an additional check for whether BYTE_ORDER is defined by the compiler to fix these.