github-upload-release.py: Fix bug preventing release creation #84571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After aa02002 we started passing the user name to the create_release function and this was being interpreted as the git tag.
boomanaiden154
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
LGTM. Wish I would've caught this in the original patch that changed this. Probably again highlights the need for better testing when someone has time to get that done.
I don't think there's an easy way to catch this with static analysis either. Typing annotations/running something like pytype wouldn't catch this since everything would just end up being strings.
|
/cherry-pick 0b9ce71 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Apr 11, 2024
|
/pull-request #88425 |
tstellar
added a commit
to llvmbot/llvm-project
that referenced
this pull request
Apr 15, 2024
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After aa02002 we started passing the user name to the create_release function and this was being interpreted as the git tag.