Skip to content

release/18.x: [SystemZ] Handle address clobbering in splitMove(). (#92105) #92221

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented May 15, 2024

Backport d6ee7e8

Requested by: @nikic

@llvmbot llvmbot added this to the LLVM 18.X Release milestone May 15, 2024
@llvmbot
Copy link
Member Author

llvmbot commented May 15, 2024

@uweigand What do you think about merging this PR to the release branch?

Copy link
Member

@uweigand uweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When expanding an L128 (which is used to reload i128) it is
possible that the quadword destination register clobbers an
address register. This patch adds an assertion against the case
where both of the expanded parts clobber the address, and in the
case where one of the expanded parts do so puts it last.

Fixes llvm#91437

(cherry picked from commit d6ee7e8)
@tstellar tstellar merged commit 9acb41b into llvm:release/18.x May 16, 2024
9 of 10 checks passed
@tstellar
Copy link
Collaborator

@nikic (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants