[mlirc] Add missing extern C #95829
Merged
[mlirc] Add missing extern C #95829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Jacques Pienaar (jpienaar) Changes
Full diff: https://github.com/llvm/llvm-project/pull/95829.diff 1 Files Affected:
diff --git a/mlir/include/mlir-c/Rewrite.h b/mlir/include/mlir-c/Rewrite.h
index 45218a1cd4ebd..bed93045f4b50 100644
--- a/mlir/include/mlir-c/Rewrite.h
+++ b/mlir/include/mlir-c/Rewrite.h
@@ -19,6 +19,10 @@
#include "mlir-c/Support.h"
#include "mlir/Config/mlir-config.h"
+#ifdef __cplusplus
+extern "C" {
+#endif
+
//===----------------------------------------------------------------------===//
/// Opaque type declarations (see mlir-c/IR.h for more details).
//===----------------------------------------------------------------------===//
@@ -57,4 +61,8 @@ mlirRewritePatternSetFromPDLPatternModule(MlirPDLPatternModule op);
#undef DEFINE_C_API_STRUCT
+#ifdef __cplusplus
+}
+#endif
+
#endif // MLIR_C_REWRITE_H
|
Don't know why didn't fail elsewhere, but failed on Windows build while linking Python libs. Signed-off-by: Jacques Pienaar <jpienaar@google.com>
joker-eph
reviewed
Jun 18, 2024
| @@ -57,4 +61,8 @@ mlirRewritePatternSetFromPDLPatternModule(MlirPDLPatternModule op); | |||
|
|
|||
| #undef DEFINE_C_API_STRUCT | |||
|
|
|||
| #ifdef __cplusplus | |||
| } | |||
| #endif | |||
There was a problem hiding this comment.
Is any of these covered by C unit-tests?
nirvedhmeshram
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Jun 20, 2024
This was missing being wrapped in extern C block. Don't know why didn't fail elsewhere, but failed on Windows build while linking Python libs. Signed-off-by: Jacques Pienaar <jpienaar@google.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing being wrapped in extern C block.
Don't know why didn't fail elsewhere, but failed on Windows build while linking Python libs.