Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: update llvm tag to 2dde4ba6 #1229

Merged
merged 1 commit into from
Aug 16, 2022
Merged

build: update llvm tag to 2dde4ba6 #1229

merged 1 commit into from
Aug 16, 2022

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Aug 16, 2022

Summary of changes:

  • Tensor dialect now sets emitAccessorPrefix to prefixed, thus
    requring updates to methods that retrieve arguments
    [https://reviews.llvm.org/D131361]
  • Update MHLO to build with LLVM commit hash 2dde4ba
  • Replace AbsOp with AbsFOp [https://reviews.llvm.org/D131325]
  • Replace deprecated getValue() with value()
    [https://reviews.llvm.org/D131349]
  • Remove AnalysisState::defaultInitialize()
    [https://reviews.llvm.org/D131746]
  • Update MHLO MLIR tests to use the updated assembly format
  • Disabled two failing TOSA tests (Github Issue link:
    Investigate failure of ElementwiseReluModule and ResNet18StaticModule TOSA tests #1231)

@ashay ashay requested review from silvasean and powderluv August 16, 2022 01:32
@ashay ashay marked this pull request as ready for review August 16, 2022 01:36
@ashay ashay changed the title [draft] build: update llvm tag to 2dde4ba6 build: update llvm tag to 2dde4ba6 Aug 16, 2022
Copy link
Collaborator

@powderluv powderluv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Summary of changes:
 - Tensor dialect now sets `emitAccessorPrefix` to prefixed, thus
   requring updates to methods that retrieve arguments
   [https://reviews.llvm.org/D131361]
 - Update MHLO to build with LLVM commit hash 2dde4ba
 - Replace `AbsOp` with `AbsFOp` [https://reviews.llvm.org/D131325]
 - Replace deprecated `getValue()` with `value()`
   [https://reviews.llvm.org/D131349]
 - Remove `AnalysisState::defaultInitialize()`
   [https://reviews.llvm.org/D131746]
 - Update MHLO MLIR tests to use the updated assembly format
 - Disabled two failing TOSA tests (Github Issue link:
   #1231)
@ashay
Copy link
Collaborator Author

ashay commented Aug 16, 2022

Merging this now, since a few folks are blocked on this PR. @sjarus and @Shukla-Gaurav, I disabled a couple of Tosa tests that were failing, but I am tracking the debugging effort in Issue #1231.

@ashay ashay merged commit 84d345c into llvm:main Aug 16, 2022
@ashay ashay deleted the ashay/llvm-tag-update branch August 16, 2022 06:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants