Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add conv system in cli #2098

Merged
merged 3 commits into from
Aug 2, 2023
Merged

add conv system in cli #2098

merged 3 commits into from
Aug 2, 2023

Conversation

Trangle
Copy link
Contributor

@Trangle Trangle commented Jul 27, 2023 •
edited
Loading

Why are these changes needed?

  1. Debugging dialogue performance under different character settings

Related issue number (if applicable)

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

@laidybug
Copy link
Contributor

This seems to have some overlap with #2069. although each focuses on a different area of the codebase.

@merrymercy merrymercy merged commit 6031ebb into lm-sys:main Aug 2, 2023
@Trangle Trangle deleted the cli_system branch August 2, 2023 03:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trangle @laidybug @merrymercy