Fix(exporter-tokens): Camel case invariant Xlarge and Xsmall strings #1932
+56
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
crishpeen,
pavelklibani,
curdaj and
a team
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
pavelklibani
approved these changes
Feb 27, 2025
adamkudrna
reviewed
Mar 4, 2025
Comment on lines
+32
to
+33
| // This will not work in this implementation: `size-xxlarge`-> `sizeXXlarge` | ||
| // ['size-xxlarge', 'sizeXXLarge'], |
There was a problem hiding this comment.
How difficult is it to implement? Isn't it all about matching xx first and then trying x?
Because I think anyone can extend the scales anytime, so we should be ready for that.
There was a problem hiding this comment.
This is not a big deal, however, this is some kind of exception and @crishpeen has doubts about this change.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts strings like
heading-xsmalltoheadingXSmallcamel case. This is applied only for characters going after theXso it can have some drawbacks.For instance
xxlargewill be transformed to theXXlarge. We can also address this problem. But this should be only applied to the T-shirt sizes.Additional context
Issue reference