Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix(web): Prevent Skeleton SCSS from failing if tokens are not found #DS-1692 #1964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(web): Prevent Skeleton SCSS from failing if tokens are not found #DS-1692 #1964

wants to merge 1 commit into from
+77 −57

Conversation

katerinarehorkova
Copy link
Contributor

Description

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1692

@netlify Netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 6694e79
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67c7f18ad819ae0008a37091

@github-actions github-actions bot added the bug Something isn't working label Feb 28, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 6694e79
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67c7f18a8830a300097726f9
😎 Deploy Preview https://deploy-preview-1964--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@katerinarehorkova katerinarehorkova added the run-visual-tests Runs visual regression testing on this PR label Mar 3, 2025
@katerinarehorkova katerinarehorkova marked this pull request as ready for review March 3, 2025 07:36
literat
literat approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

crishpeen
crishpeen reviewed Mar 4, 2025
View reviewed changes
adamkudrna
adamkudrna approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once everything is resolved, a ✅ for me.

@katerinarehorkova katerinarehorkova force-pushed the fix/ds-1692-skeleton-tokens-check branch from 707ded0 to 6694e79 Compare March 5, 2025 06:39
@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling 6694e79 on fix/ds-1692-skeleton-tokens-check
into dd2c5ed on main.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@crishpeen crishpeen crishpeen left review comments

@literat literat literat approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@katerinarehorkova katerinarehorkova

Labels
bug Something isn't working run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@katerinarehorkova @coveralls @literat @adamkudrna @crishpeen @pavelklibani