Fix(web-react): Forgotten elementType in useStyleProps hook #1970
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
curdaj,
katerinarehorkova and
a team
as code owners
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dlouhak
reviewed
Mar 3, 2025
| @@ -40,7 +40,7 @@ const Collapse = (props: SpiritCollapseProps) => { | |||
|
|
|||
| const { classProps } = useCollapseStyleProps(restProps.isOpen); | |||
| const { ariaProps, props: otherProps } = useCollapseAriaProps(restProps); | |||
| const { styleProps, props: transferProps } = useStyleProps({ ElementTag, ...otherProps }); | |||
| const { styleProps, props: transferProps } = useStyleProps(otherProps); | |||
There was a problem hiding this comment.
Wouldn't be bulletproof to edit restPropsTest.tsx, so it will be caught earlier?
crishpeen
approved these changes
Mar 4, 2025
pavelklibani
force-pushed
the
fix/element-type-in-style-props
branch
from
40ce5d9 to
e972e15
Compare
cannot reproduce |
pavelklibani
force-pushed
the
fix/element-type-in-style-props
branch
from
e972e15 to
1fa086d
Compare
- element tag was forwarded to dom element
pavelklibani
force-pushed
the
fix/element-type-in-style-props
branch
from
1fa086d to
0dfef7e
Compare
|
rebased with main |
curdaj
approved these changes
Mar 5, 2025
literat
approved these changes
Mar 5, 2025
katerinarehorkova
approved these changes
Mar 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference