Add "down" method for migrations #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure. I can't see anyone ever needing these tbh but can't hurt. |
|
Thanks! |
vmiguellima
added a commit
to vmiguellima/lemonsqueezy-laravel
that referenced
this pull request
May 15, 2023
* Update README.md * Add method * Allow checkout to create subscriptions * Use constant * Fix import * Add docs for payment method overlay * Fix code styling * Fix customer creation * Update LemonSqueezy.php * Update CHANGELOG * Update README.md * Update README.md * Add note about updating customers * Update CHANGELOG.md * added drop methods to migrations (lmsqueezy#19) * Change URL to find lmnsqueezy store ID in README.md (lmsqueezy#20) I could not find the ID in the "General" Settings but found it in the "Stores" settings. * Overwriting package migrations --------- Co-authored-by: Dries Vints <dries@vints.be> Co-authored-by: driesvints <driesvints@users.noreply.github.com> Co-authored-by: George Daneke <Flatroy@users.noreply.github.com> Co-authored-by: Sebastian Hilger <hilger@kraenk.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am aware that the use of "down" methods in our migrations is typically unnecessary these days. However, it is still considered standard practice in Laravel, isn't it? With that in mind, I have submitted a pull request to include it.
Thank you for your great work,
George