Primera versión de la actividad inicial para revisión. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerVeraDev
reviewed
Nov 23, 2021
| { | ||
| private readonly ProviderService service; | ||
| private readonly IMapper mapper; | ||
|
|
There was a problem hiding this comment.
Podes inyectar la interfaz ILogger
Aqui un breve video, por si es la primera vez que escuchas sobre ILogger
https://www.youtube.com/watch?v=-P-MHeTZBSA
Y usarla por ejemplo, en bloques try - catch.
Donde pensas que podes incluir (en los metodos creados) o anterior ?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basándome en la documentación y algunos comentarios de Discord, creo que logré completar la actividad inicial. Hice algunas pruebas en Swagger UI y los 6 tests corrieron satisfactoriamente.
Issues
Tuve problemas que comenté en Discord relacionados con la instalación de paquetes de NuGet, y también un problema con una DLL que no encontraba Visual Studio llamada testhost.dll. Lo resolví instalando el paquete Microsoft.NET.Test.Sdk.
Opinion
El curso me parece muy bueno, pero no tengo conocimientos previos de C# y siento que algunas cosas las entendí y otras las copié y modifiqué. Apreciaré cualquier sugerencia o recurso adicional que puedan pasarme. Agradezco la oportunidad de aprender con ustedes.