Implementación de las tareas solicitadas en la primera reunion #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerVeraDev
reviewed
Nov 29, 2021
| try | ||
| { | ||
| var result = service.Get(id); | ||
| if (result == null) |
There was a problem hiding this comment.
Esto esta bien? cuando la variable result es null, se hace un maper... y cuando es distinto de null, devolves un "NotFound" .. Verificar
| var result = service.GetAll(); | ||
| return mapper.Map<IEnumerable<ProviderDTO>>(result).ToList(); | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
En esta linea, estaria bueno ser consistente con la linea 47, y tambien loggear el posible error .. Ademas estas usando la sobrecarga del catch y no estas usando la variable "ex".
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aquí deberías agregar un resumen del trabajo que realizaste.
Issues
Aquí deberías contar si tuviste algún problema o en el caso de que reportaste un issue.
Ej:
Related to #(issue)
Fixes # (issue)
Opinion
Si querés dejar algún comentario al respecto: improvements, mistakes, weaknesses.