Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add basic github action for regression testing #81

Merged
merged 5 commits into from
May 16, 2024

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Dec 28, 2023

Adds a basic GitHub action regression test to verify that basic awslocal commands are still working.

Can be extended with multiple other cases as well like:

  • More awslocal ... service calls
  • Different configurations
  • awscli v1 vs. v2
  • ...

@dominikschubert dominikschubert self-assigned this Dec 28, 2023
@dominikschubert dominikschubert marked this pull request as ready for review December 28, 2023 10:38
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great to see this covered by some basic smoke/regression tests @dominikschubert ! 🚀 Nice idea with the multi-account testing for 000000000001 as well 👌

which aws
which awslocal

- name: Start and wait for localstack (Community)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: At some point in the future we could start dogfooding our own Github Action.. https://github.com/localstack/setup-localstack 😎 (no need to change for now, though..)

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! These tests were long overdue! 🥇 💯

@dominikschubert
Copy link
Member Author

Thanks @alexrashed for pointing out that this is still open 😅

@dominikschubert dominikschubert merged commit 167f42b into master May 16, 2024
@dominikschubert dominikschubert deleted the basic-regression-test branch May 16, 2024 07:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants