Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add SQLite parser for Android Viber Call (viber_data) file #4934

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aurelioklv
Copy link

@aurelioklv aurelioklv commented Dec 3, 2024

One line description of pull request

Add SQLite parser for Android Viber Call (viber_data) file

Description:

I add and modify several files:

  • Add import android_viber_call to plaso/parsers/sqlite_plugins/__init__.py
  • Add a new parser plugin android_viber_call.py to plaso/parsers/sqlite_plugins/
  • Add viber_data file to test_data/
  • Add unit test android_viber_call.py to tests/parsers/sqlite_plugins/
  • Modify android.yaml to support Android Viber Call parser plugin (plaso/data/formatters/android.yaml)
  • Modify timeliner.yaml to support Android Viber Call parser plugin (plaso/data/timeliner.yaml)

Related issue (if applicable): fixes #

Notes:

All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned
  • Test data has a Plaso compatible license

@joachimmetz
Copy link
Member

Thanks for the PR, I'm a bit preoccupied at the moment will try to take a look as soon as time permits

@joachimmetz
Copy link
Member

@aurelioklv what is the origin of the test data file?

@joachimmetz joachimmetz self-assigned this Mar 4, 2025
@joachimmetz joachimmetz added the pending reporter input Issue is pending input from the reporter label Mar 4, 2025
@joachimmetz
Copy link
Member

Rebased PR

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (11259d3) to head (c1887c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4934      +/-   ##
==========================================
+ Coverage   85.09%   85.10%   +0.01%     
==========================================
  Files         432      433       +1     
  Lines       38792    38828      +36     
==========================================
+ Hits        33009    33045      +36     
  Misses       5783     5783              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pending reporter input Issue is pending input from the reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants